felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard S. Hall" <he...@ungoverned.org>
Subject Re: Refactor bundlerepositorty and obr related code from maven-bundle-plugin ?
Date Wed, 17 Mar 2010 19:23:56 GMT
On 3/17/10 12:21, Guillaume Nodet wrote:
> One thing I'm struggling with is the number of other projects included in
> the maven-bundle-plugin.
> It seems we include the whole bindex code, obr plugins, some maven bits.
> There are a lot of duplication here.
> For bindex, why do we include it ? It is mostly redundant with the
> bundlerepository.
>    

We don't include bindex in OBR, so I am not sure how that is redundant. 
I believe bindex is included in maven-bundle-plugin because it needs to 
generate repository.xml files from the generated bundle files.

-> richard

> I think I'm going to refactor the whole thing unless there is something
> obvious I'm missing here.
>
> On Wed, Mar 17, 2010 at 10:32, Guillaume Nodet<gnodet@gmail.com>  wrote:
>
>    
>> Both bundlerepository and maven-bundle-plugin contain similar code
>> like the RepositoryImpl, BundleInfo (quite similar to the
>> LocalResourceImpl from bundlerepository), repository xml parser,
>> etc...
>> I think it would make more sense to enhance the ones in
>> bundlerepostiory and reuse those from the maven-bundle-plugin rather
>> than keep the duplication.
>>
>> Thoughts ?
>>
>> --
>> Cheers,
>> Guillaume Nodet
>> ------------------------
>> Blog: http://gnodet.blogspot.com/
>> ------------------------
>> Open Source SOA
>> http://fusesource.com
>>
>>      
>
>
>    

Mime
View raw message