felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Pauls (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FELIX-2195) Using URLDecoder.decode on locations is wrong
Date Fri, 12 Mar 2010 08:53:27 GMT

    [ https://issues.apache.org/jira/browse/FELIX-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844427#action_12844427
] 

Karl Pauls commented on FELIX-2195:
-----------------------------------

Thanks. Do you need a 2.0.5 release quickly for geronimo or can you stay on trunk for a while?

> Using URLDecoder.decode on locations is wrong
> ---------------------------------------------
>
>                 Key: FELIX-2195
>                 URL: https://issues.apache.org/jira/browse/FELIX-2195
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: felix-2.0.4
>            Reporter: David Jencks
>         Attachments: FELIX-2195.diff
>
>
> URLDecoder is supposed to be for decoding form goo stuffed into a url, not for decoding
the path component of a url.  Using it for this produces wrong results.  In partucular, mac
os x likes to make temporary files with strings like "+++++++" in the path.  When run through
URLDecoder these turn into spaces which means felix can't find the file you just gave it a
valid file system location for.  Since equinox does this correctly we can't use felix in geronimo
until this is fixed.
> IIUC URLDecoder is used as an attempt to maintain compatibility with ancient vms that
lack URI and its correct decoding behavior.  Fortunately apache harmony implements URI so
the attached patch borrows the implementation from harmony to provide correct behavior on
antique vms.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message