Return-Path: Delivered-To: apmail-felix-dev-archive@www.apache.org Received: (qmail 68539 invoked from network); 10 Jan 2010 19:29:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 10 Jan 2010 19:29:18 -0000 Received: (qmail 71641 invoked by uid 500); 10 Jan 2010 19:29:18 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 71574 invoked by uid 500); 10 Jan 2010 19:29:18 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 71509 invoked by uid 99); 10 Jan 2010 19:29:18 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Jan 2010 19:29:18 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Jan 2010 19:29:16 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 619B5234C1F1 for ; Sun, 10 Jan 2010 11:28:55 -0800 (PST) Message-ID: <2009989190.146161263151735398.JavaMail.jira@brutus.apache.org> Date: Sun, 10 Jan 2010 19:28:55 +0000 (UTC) From: "Karl Pauls (JIRA)" To: dev@felix.apache.org Subject: [jira] Issue Comment Edited: (FELIX-325) Factor out security checks from the framework/system bundle code In-Reply-To: <25811875.1184010426201.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/FELIX-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798532#action_12798532 ] Karl Pauls edited comment on FELIX-325 at 1/10/10 7:27 PM: ----------------------------------------------------------- I think that should be ok now as we extend BundleImpl and only need the checks for specific methods (I had a look and i don't think we have too much duplication). was (Author: karlpauls): I think that should be ok now as we implement BundleImpl and only need the checks for specific methods (I had a look and i don't think we have too much duplication). > Factor out security checks from the framework/system bundle code > ---------------------------------------------------------------- > > Key: FELIX-325 > URL: https://issues.apache.org/jira/browse/FELIX-325 > Project: Felix > Issue Type: Improvement > Components: Framework > Affects Versions: felix-1.0.0 > Reporter: Richard S. Hall > Assignee: Karl Pauls > Fix For: felix-2.2.0 > > > Now that the framework implements the Bundle interface, it must also perform the same security checks as BundleImpl. This results in code duplication. We should think about how we can factor this code out, perhaps in the SecureAction class so that both the framewwork and BundleImpl can use it and avoid duplicating it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.