Return-Path: Delivered-To: apmail-felix-dev-archive@www.apache.org Received: (qmail 87813 invoked from network); 23 Nov 2009 10:00:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 23 Nov 2009 10:00:42 -0000 Received: (qmail 72245 invoked by uid 500); 23 Nov 2009 10:00:42 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 72156 invoked by uid 500); 23 Nov 2009 10:00:41 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 72146 invoked by uid 99); 23 Nov 2009 10:00:41 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Nov 2009 10:00:41 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of tonit.com@googlemail.com designates 209.85.212.201 as permitted sender) Received: from [209.85.212.201] (HELO mail-vw0-f201.google.com) (209.85.212.201) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Nov 2009 10:00:30 +0000 Received: by vws39 with SMTP id 39so4822748vws.30 for ; Mon, 23 Nov 2009 02:00:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to :content-type; bh=qLWiTDmVQ158TvAyCijLX1BUPivy8vGm0lW4ZegEvGM=; b=vX+41UoOsFv9SmiU73oFUtsj0ifEANd04uQEjGLCo6pH27MwJ7fbyUTjcZF8g9eVtD 1yYMFmvwrihplfaVpT/T+b1AMOIMUH0gwD9x9DN9t+vv0q04XmLTyjebea7LnFS/TwkU Rb73Pm17cabe9ysj+923RN6AEjfIPmtRy1kAQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; b=bZgOwAOrp54cTKZn47GPFHVeJqgGnUs6RtkMS0TmZ3NcVkoarEYYV8oHJx6TIdiTYz CTC9vxl7mHjKNk7Wo87Eyu/Pmw5QWPiqYUPYgWm63OuVzSzsiuuzbtQ0wwSw9VDY2Hdb wuOdvqPNzGLN3+W9rVGuQ9UiQ+rzRvuc/FQnY= MIME-Version: 1.0 Sender: tonit.com@googlemail.com Received: by 10.220.121.155 with SMTP id h27mr5532751vcr.20.1258970406276; Mon, 23 Nov 2009 02:00:06 -0800 (PST) In-Reply-To: <4B0A58F2.9070202@gmail.com> References: <4B0A55E0.3030601@gmail.com> <4B0A58F2.9070202@gmail.com> Date: Mon, 23 Nov 2009 11:00:06 +0100 X-Google-Sender-Auth: fb1e56d0a9043937 Message-ID: Subject: Re: Continuous build updated to Maven 2.2.1 From: Toni Menzel To: dev@felix.apache.org Content-Type: multipart/alternative; boundary=001636c93192d94f17047906e37f X-Virus-Checked: Checked by ClamAV on apache.org --001636c93192d94f17047906e37f Content-Type: text/plain; charset=ISO-8859-1 On Mon, Nov 23, 2009 at 10:42 AM, Felix Meschberger wrote: > Hi, > > Toni Menzel schrieb: > > On Mon, Nov 23, 2009 at 10:29 AM, Felix Meschberger >wrote: > > > >> Hi, > >> > >> Toni Menzel schrieb: > >>> This is actually "home made" by placing integration tests in the > >> component > >>> under test. > >>> This way you create a chicken egg problem. The tests (executed before > >> bundle > >>> is being packaged, see maven lifecycle) grabs any older version of the > >>> component it finds (matching the group+artifact+version) wich usually > not > >>> what you want to test. > >> No, this is probably not a chicken/egg problem: the integration tests > >> run in the integration-test phase, which comes after packaging. Moreover > >> the SCR bundle under test is loaded from the local target folder and not > >> through maven to ensure using the correct version. > >> > > > > Always learning new things;) Actually i never use the integration-test > phase > > because of "prefer mvn install over mvn package". So I would never rely > in > > package builds when using a bigger reactor builds. > > Because of that you are back to the chicken-egg. - you cannot really > > "revoke" a install(ed) build. > > Point is that this is roughly the order of phases: > > process resources > compile > unit tests > package > integration-test > install > deploy > > So, the integration-test phase always comes _after_ the packaging but > before (locally) installing. So if an integration test fails, the local > install (and remote deployment) don't take place. > > See also > > http://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html > > Quite nice ;-) Sure, i am aware of that but.. was more pointing to the fact of not trusting mvn package builds (rather than mvn install) when having a multi project build. However, was not aware that you (in SCR) use a self made provisioning system. Have you had trouble of fetching artifacts from local repo (instead of target) before ? > > Regards > Felix > > > > > > Anyway, if it works for scr, very good! Should have looked into it a bit > > deeper. ;) > > > > > >> So, it is rather related to test timing issues, I fear. > >> > >> I will look into hardening the tests ... until then there might be some > >> builds which fail due to SCR and/or configadmin -- especially since we > >> build everything at once. > >> > >>> Solution: put the integration tests into its own projects. Sounds nuts > >> but > >>> is just logical. > >>> Also it would be good to upgrade to exam 1.2.0 (currently 0.6). > >> Ok, thanks for pointing to this new release. Will update. > >> > >> Regards > >> Felix > >> > >>> Toni > >>> > >>> On Sat, Nov 21, 2009 at 5:52 PM, Marcel Offermans < > >>> marcel.offermans@luminis.nl> wrote: > >>> > >>>> I just updated the continuous build, running on Bamboo, to Maven 2.2.1 > >>>> because I needed a feature (compiling tests against a different > >>>> source/target JVM than the bundle itself) which seemed to be broken in > >>>> earlier versions. > >>>> > >>>> Initially, after going to the new Maven, a test case failed, but > running > >>>> the build again made it succeed, so I'm assuming there is some kind of > >> race > >>>> condition in the test. See: > >>>> > >>>> > >>>> > >> > http://opensource.bamboo.atlassian.com/build/viewTestCaseHistory.action?buildKey=FELIX-DEF&testClassName=org.apache.felix.scr.integration.ServiceBindTest&testCaseName=test_optional_single_static > >>>> Perhaps one of the SCR guys could have a look at this? > >>>> > >>>> Greetings, Marcel > >>>> > >>>> > >>> > > > > > > > -- Toni Menzel Independent Software Developer Professional Profile: http://okidokiteam.com toni@okidokiteam.com http://www.ops4j.org - New Energy for OSS Communities - Open Participation Software. --001636c93192d94f17047906e37f--