felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jamie goodyear (JIRA)" <j...@apache.org>
Subject [jira] Updated: (FELIX-1877) karaf.main.BootstrapLogManager possible resource leak and ignored exception in open method.
Date Wed, 18 Nov 2009 17:46:40 GMT

     [ https://issues.apache.org/jira/browse/FELIX-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jamie goodyear updated FELIX-1877:
----------------------------------

    Attachment: felix-1877.patch

File: felix-1877.patch

Contains two small fixes:

1) Includes finally block to ensure the opened input stream is closed after use.

2) Captures possible security exception during mkdirs call and wraps as IOException.



> karaf.main.BootstrapLogManager possible resource leak and ignored exception in open method.
> -------------------------------------------------------------------------------------------
>
>                 Key: FELIX-1877
>                 URL: https://issues.apache.org/jira/browse/FELIX-1877
>             Project: Felix
>          Issue Type: Bug
>          Components: Karaf
>            Reporter: Jamie goodyear
>            Priority: Minor
>         Attachments: felix-1877.patch
>
>
> May fail to close stream:
> o.a.f.k.main.bootstrapLogManager.getDefaultHandler() line 54
> Need to close java.io.inputStream.
> Method ignores excetional return value:
> o.a.f.k.main.BootstrapLogManager$SimpleFileHandler.open(File, boolean) line 90
> Called method java.io.File.mkdirs().
> Capture possible exception.
> Issues detected during run of static analysis tool.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message