Mailing-List: contact dev-help@felix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@felix.apache.org
Message-ID: <159284929.1255349731366.JavaMail.jira@brutus>
Date: Mon, 12 Oct 2009 05:15:31 -0700 (PDT)
From: "Guillaume Nodet (JIRA)" <jira@apache.org>
To: dev@felix.apache.org
Subject: [jira] Resolved: (FELIX-1682) The newly installed bundles for a
 feature should be uninstalled when feature install failed
In-Reply-To: <1069417298.1254457343580.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/FELIX-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Nodet resolved FELIX-1682.
------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: karaf-1.2.0)
                   karaf-1.0.2
         Assignee: Guillaume Nodet

Committing to https://svn.apache.org/repos/asf/felix/trunk ...
	M	karaf/features/command/src/main/java/org/apache/felix/karaf/features/command/InstallFeatureCommand.java
	M	karaf/features/core/src/main/java/org/apache/felix/karaf/features/FeaturesService.java
	M	karaf/features/core/src/main/java/org/apache/felix/karaf/features/internal/FeaturesServiceImpl.java
Committed r824313

I'm sorry I did no see you patch before committing my fix.
My patch is more general and add an option to the command to be able to not clean bundles (this can be useful when debugging a feature so that you don't have to manually install all the bundles).  My patch also rollback dependant features installation upon failures.

> The newly installed bundles for a feature should be uninstalled when feature install failed
> -------------------------------------------------------------------------------------------
>
>                 Key: FELIX-1682
>                 URL: https://issues.apache.org/jira/browse/FELIX-1682
>             Project: Felix
>          Issue Type: Improvement
>          Components: Karaf
>            Reporter: richard stone
>            Assignee: Guillaume Nodet
>            Priority: Minor
>             Fix For: karaf-1.0.2
>
>         Attachments: Felix-1682.patch
>
>
> Start Karaf 1.1.0 snapshot, type "features:install webconsole", at first, it will throw an exception "can not get org.apache.felix.karaf.webconsole.admin-1.1.0-SNAPSHOT.jar", run "osgi:list", you can see some bundles listed in this feature(like org.apache.felix.metatype) are installed. My point is if the feature install failed then the newly installed bundles should be uninstalled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.