felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jed Wesley-Smith (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FELIX-1746) Eliminate contention on ServiceRegistry.getServiceReferences(String, Filter)
Date Wed, 14 Oct 2009 23:44:31 GMT

    [ https://issues.apache.org/jira/browse/FELIX-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765817#action_12765817
] 

Jed Wesley-Smith commented on FELIX-1746:
-----------------------------------------

> Question, you state that HotSpot will conflate the two subsequent lock acquires into
one, can you provide a reference? I have not been able to find one...

Don't worry, found it: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6245809

> Eliminate contention on ServiceRegistry.getServiceReferences(String, Filter)
> ----------------------------------------------------------------------------
>
>                 Key: FELIX-1746
>                 URL: https://issues.apache.org/jira/browse/FELIX-1746
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: felix-2.0.0
>            Reporter: Jed Wesley-Smith
>            Assignee: Karl Pauls
>         Attachments: blocked-threads.gif.jpg, FELIX-1746-alt.patch, FELIX-1746-alt2.patch,
FELIX-1746.patch
>
>
> Performance testing has shown that there is significant contention on the ServiceRegistry
object's monitor during startup. This is caused by Spring DM making lots of calls to the synchronized
method ServiceRegistry.getServiceReferences(String, Filter). This method is synchronized in
order to protect the m_serviceRegsMap HashMap, but the method does a lot more work than simply
accessing the map.
> Propose changing the ServiceRegistry to use a thread-safe Map implementation that does
not require external synchronization, in particular a CopyOnWriteMap. I will add a patch that
includes a CopyOnWriteMap implementation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message