Mailing-List: contact dev-help@felix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@felix.apache.org
Received-SPF: pass (nike.apache.org: domain of gnodet@gmail.com designates
 209.85.218.205 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=ZcgfgietajOjtDtWeWSMEE4VaU7eI2wfAb1AhBadFiNuq3WaGzPwaoJGAsp+LLwNU+
         47QK4rM5I6lfZdS/q5EvQZyu+njxUCKx6ryvdkcxe2R2Ob2KV0NyNwdAHZKnZOGg89gj
         XzUE17LEpnkYu37+qc+B96Ls78XbvmfdN9d9w=
MIME-Version: 1.0
In-Reply-To: <b23ecedc0909030132q14773021wd6eae0aec0cbfc02@mail.gmail.com>
References: <b23ecedc0909030129i46cbefdbj1cdd1ef0349b9ed3@mail.gmail.com>
	 <b23ecedc0909030132q14773021wd6eae0aec0cbfc02@mail.gmail.com>
Date: Thu, 3 Sep 2009 15:55:18 +0200
Message-ID: <b23ecedc0909030655v114b772at5a3b983f757947de@mail.gmail.com>
Subject: Re: Packages exported by fileinstall
From: Guillaume Nodet <gnodet@gmail.com>
To: dev <dev@felix.apache.org>
Content-Type: multipart/alternative; boundary=001517473644db704e0472acbb8d

--001517473644db704e0472acbb8d
Content-Type: text/plain; charset=ISO-8859-1

So I've changed fileinstall to optionally import the log service package
instead of exporting it.

I also have a local modification where I moved the classes in different
packages:
   * interfaces that are currently in o.a.f.fileinstall.listener move to
o.a.f.fileinstall
   * all other classes move to o.a.f.fileinstall.internal
   * the bundle exports o.a.f.fileinstall package, but not the .internal one
which contain al the implementation classes

I think this would be cleaner and more inlined with best practices.
Unless there's a problem with that, I'm planning to commit that change soon.

On Thu, Sep 3, 2009 at 10:32, Guillaume Nodet <gnodet@gmail.com> wrote:

> Btw, I also wonder about the need to export the
> org.apache.felix.fileinstall package, as this one only contains
> implementation classes and should be private imho.  Have anyone seen a need
> to really export this package ?
>
>
> On Thu, Sep 3, 2009 at 10:29, Guillaume Nodet <gnodet@gmail.com> wrote:
>
>> Fileinstall exports the org.osgi.service.cm and org.osgi.service.log
>> packages.
>> I wonder if this would make more sense to make them optional import and
>> make sure the code can run if those are not wired.
>> As a side effect would also reduce the size of the jar and simplify the
>> resolution process (I don't having having bundles exporting the same package
>> really helps ...)
>> Thoughts ?
>>
>> --
>> Cheers,
>> Guillaume Nodet
>> ------------------------
>> Blog: http://gnodet.blogspot.com/
>> ------------------------
>> Open Source SOA
>> http://fusesource.com
>>
>>
>>
>
>
> --
> Cheers,
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> Open Source SOA
> http://fusesource.com
>
>
>


-- 
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com

--001517473644db704e0472acbb8d--