Return-Path: Delivered-To: apmail-felix-dev-archive@www.apache.org Received: (qmail 9820 invoked from network); 17 Sep 2009 22:36:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 17 Sep 2009 22:36:23 -0000 Received: (qmail 94133 invoked by uid 500); 17 Sep 2009 22:36:22 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 94057 invoked by uid 500); 17 Sep 2009 22:36:22 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 94047 invoked by uid 99); 17 Sep 2009 22:36:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Sep 2009 22:36:22 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Sep 2009 22:36:19 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 10B6A234C1F2 for ; Thu, 17 Sep 2009 15:35:58 -0700 (PDT) Message-ID: <1606201140.1253226958063.JavaMail.jira@brutus> Date: Thu, 17 Sep 2009 15:35:58 -0700 (PDT) From: "Derek Baum (JIRA)" To: dev@felix.apache.org Subject: [jira] Closed: (FELIX-1406) eclipse code format template does not match existing code In-Reply-To: <1960229664.1248422419675.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/FELIX-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Derek Baum closed FELIX-1406. ----------------------------- Resolution: Fixed eclipse template now correctly reflects felix coding standards. > eclipse code format template does not match existing code > --------------------------------------------------------- > > Key: FELIX-1406 > URL: https://issues.apache.org/jira/browse/FELIX-1406 > Project: Felix > Issue Type: Bug > Components: Documentation > Reporter: Derek Baum > Priority: Minor > Attachments: Apache Felix Eclipse Template.xml, ApacheFelixEclipseTemplate.xml > > > The eclipse code format template http://felix.apache.org/site/coding-standards.data/ApacheFelixCodingStandards.xml > generates slightly different white space and blank line formatting than existing felix code. > Specifically: > 1. spaces are inserted after the opening paren and before the closing paren in declarations and method calls: > int method1( String arg1 ) > { > if ( expr ) > { > method1( arg1 ); > } > } > The felix coding standards document http://felix.apache.org/site/coding-standards.html does not specifically specify these spaces, > but all the examples show code formatted without them. > 2. two blank lines are inserted after package statement and between method declarations > This actually agrees with the eclipse template, but the code I was reformatting (gogo) only had one blank line. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.