Return-Path: Delivered-To: apmail-felix-dev-archive@www.apache.org Received: (qmail 74499 invoked from network); 17 Aug 2009 15:49:34 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 17 Aug 2009 15:49:34 -0000 Received: (qmail 18575 invoked by uid 500); 17 Aug 2009 15:49:40 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 18495 invoked by uid 500); 17 Aug 2009 15:49:39 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 18381 invoked by uid 99); 17 Aug 2009 15:49:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Aug 2009 15:49:39 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Aug 2009 15:49:36 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id D4856234C044 for ; Mon, 17 Aug 2009 08:49:14 -0700 (PDT) Message-ID: <1293707493.1250524154865.JavaMail.jira@brutus> Date: Mon, 17 Aug 2009 08:49:14 -0700 (PDT) From: "Guillaume Nodet (JIRA)" To: dev@felix.apache.org Subject: [jira] Commented: (FELIX-1066) Assume a default type/classified (xml/features) on the features addUrl/removeUrl commands In-Reply-To: <1112566871.1240930891544.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/FELIX-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744109#action_12744109 ] Guillaume Nodet commented on FELIX-1066: ---------------------------------------- I have a problem with this patch. It means if someone has an xml repository deployed with no maven classifier, it won't work. mvn:foo/bar/1.0/xml then this patch will automatically add /features to the uri. I think it would be better to try loading the file using the plain url, and maybe try again with /xml/features or /features appended to the uri. Or maybe it was a bad idea ... > Assume a default type/classified (xml/features) on the features addUrl/removeUrl commands > ----------------------------------------------------------------------------------------- > > Key: FELIX-1066 > URL: https://issues.apache.org/jira/browse/FELIX-1066 > Project: Felix > Issue Type: Improvement > Components: Karaf > Reporter: Guillaume Nodet > Attachments: FELIX-1066-OptionalMavenUrlComponents.patch > > > When doing an features/addUrl, you always have to specify the type (xml) and classifier (features). How about making that the default, so people can just do: > {code} > features/addUrl mvn:org.apache.servicemix.features/apache-servicemix/4.0.0 > {code} > We can always fail-back to type jar if we don't find the xml file to support deploying new feature descriptors through a bundle. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.