felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard S. Hall (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FELIX-1453) BundleArchive.createRevisionFromLocation may throw NullPointerException
Date Thu, 06 Aug 2009 14:21:14 GMT

    [ https://issues.apache.org/jira/browse/FELIX-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740079#action_12740079
] 

Richard S. Hall commented on FELIX-1453:
----------------------------------------

Hmm. Why can't it write the location file? It seems like either 1) we should have discarded
the bundle when we couldn't write the location in the first place or 2) when restarting the
exception should bubble up sooner so we never even get to this point, no?

> BundleArchive.createRevisionFromLocation may throw NullPointerException
> -----------------------------------------------------------------------
>
>                 Key: FELIX-1453
>                 URL: https://issues.apache.org/jira/browse/FELIX-1453
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: felix-1.8.1
>            Reporter: Felix Meschberger
>
> When BundleArchive.createRevisionFromLocation is called with the location being null,
a NullPointerException is thrown on line 995 (Rev. 801082).
> The fix obviously seems to be to check for null on this line and actually pass it through
like this:
> Index: src/main/java/org/apache/felix/framework/cache/BundleArchive.java
> ===================================================================
> --- src/main/java/org/apache/felix/framework/cache/BundleArchive.java	(Revision 801082)
> +++ src/main/java/org/apache/felix/framework/cache/BundleArchive.java	(Arbeitskopie)
> @@ -992,7 +992,7 @@
>                          location, true);
>                  }
>              }
> -            else if (location.startsWith(INPUTSTREAM_PROTOCOL))
> +            else if (location == null || location.startsWith(INPUTSTREAM_PROTOCOL))
>              {
>                  // Assume all input streams point to JAR files.
>                  result = new JarRevision(m_logger, m_configMap, revisionRootDir,

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message