felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guillaume Nodet (JIRA)" <j...@apache.org>
Subject [jira] Updated: (FELIX-1325) gogo doesn't report a command not found error unless an argument is supplied
Date Tue, 11 Aug 2009 10:09:14 GMT

     [ https://issues.apache.org/jira/browse/FELIX-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Guillaume Nodet updated FELIX-1325:
-----------------------------------

    Attachment: FELIX-1325.patch

Attach is an attempt to fix the issue.
There is one problem unfortunately which is related to command grouping.
I think the following tests should be true:

        assertEquals("echo b", c.execute("e = { $args } ; <e echo  echo  b | capture>"));
        assertEquals("b", c.execute("e = { $args } ; <e echo  <echo  b> | capture>"));
        assertEquals("b", c.execute("e = { $args } ; <<e echo  echo  b> | capture>"));

However, there is no distinction between command grouping and execution.  This is related
to the discussion we had about using $() and () instead of <> and I think this problem
should go away if we switch.

> gogo doesn't report a command not found error unless an argument is supplied
> ----------------------------------------------------------------------------
>
>                 Key: FELIX-1325
>                 URL: https://issues.apache.org/jira/browse/FELIX-1325
>             Project: Felix
>          Issue Type: Improvement
>          Components: Gogo
>            Reporter: Derek Baum
>            Priority: Minor
>         Attachments: FELIX-1325.patch, FELIX-1325.patch
>
>
> 2009/7/13 Hiram Chirino <chirino@gmail.com> wrote:
>     But on related note... to the gogo developers: I would have expected a
>     command not found error when you type in a command that's not found.  This
>     seems to work fine if you pass an argument to a command.  It this a 'feature' or
a bug?
> This is a 'feature', in that an undefined command silently returns itself, rather than
an error.
> This is so that:
> > x = hello
> works; otherwise the assignment would fail, with a command not found error.
> Note: that
> > x = hello world
> will actually evaluate the 'hello' command with 'world' as an argument.
> > x = "hello world"
> tries to evaulate the 'hello world' command, which probably doesn't exist, so it falls
back to returning the value, rather than unknown command.
> I think this can be simply resolved by avoiding re-evaluating an assignment with a single
argument.
> This will mean that
> > x = hello
> works as it does currently, but that
> > hello
> will fail with 'unknown command', rather than simply return itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message