felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Diesler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FELIX-1124) ResourceNotFoundException too verbose
Date Thu, 18 Jun 2009 11:27:07 GMT

    [ https://issues.apache.org/jira/browse/FELIX-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721201#action_12721201
] 

Thomas Diesler commented on FELIX-1124:
---------------------------------------

Yes, this should be place. I verified this with framework-1.8.0

Here a sample stacktrace

2009-06-18 13:19:45,074 DEBUG [org.jboss.osgi.felix.framework.FelixLogger] META-INF/services/org.apache.xerces.xni.parser.XMLParserConfiguration
org.apache.felix.moduleloader.ResourceNotFoundException: META-INF/services/org.apache.xerces.xni.parser.XMLParserConfiguration
	at org.apache.felix.framework.searchpolicy.ModuleImpl.findClassOrResourceByDelegation(ModuleImpl.java:622)
	at org.apache.felix.framework.searchpolicy.ModuleImpl.getResourceByDelegation(ModuleImpl.java:488)
	at org.apache.felix.framework.searchpolicy.ModuleImpl$ModuleClassLoader.getResource(ModuleImpl.java:1631)
	at java.lang.ClassLoader.getResourceAsStream(ClassLoader.java:1168)

> ResourceNotFoundException too verbose
> -------------------------------------
>
>                 Key: FELIX-1124
>                 URL: https://issues.apache.org/jira/browse/FELIX-1124
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: felix-1.6.1, felix-1.8.0
>            Reporter: Thomas Diesler
>
> ModuleImpl logs stack traces for every resource that cannot be found. Often resources
are optional or may be located at different locations. 
>     public URL getResourceByDelegation(String name)
>     {
>         try
>         {
>             return (URL) findClassOrResourceByDelegation(name, false);
>         }
>         catch (ClassNotFoundException ex)
>         {
>             // This should never be thrown because we are loading resources.
>         }
>         catch (ResourceNotFoundException ex)
>         {
>             m_logger.log(
>                 Logger.LOG_DEBUG,
>                 ex.getMessage(),
>                 ex);
>         }
>         return null;
>     }
> Please consider a log message without stack trace and leave it to the client to be more
verbose when appropriate. 
> To log no message at all and simply return null would also be consistent with 
> http://java.sun.com/javase/6/docs/api/java/lang/ClassLoader.html#getResource(java.lang.String)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message