Mailing-List: contact dev-help@felix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@felix.apache.org
Received-SPF: pass (athena.apache.org: domain of mcculls@gmail.com designates
 209.85.200.172 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=j/IwSbT43307iojFwTdB1TdK0Ct8PR8oMKDtk9bb1+3VH6yqQnWioGNZ7his6ZPOrP
         AJVk1sw2p/jw/vlRA9Lyzd9oJeVWhk60ZW+3hG3o5mlS5LmMzmCYkhkFVrbYl0GxZaJR
         Bp7P/WwiA8VLI1NAsTtxiNCpPCNu/shNe1+lQ=
MIME-Version: 1.0
In-Reply-To: <4A1A195D.3090008@gmail.com>
References: <4A1A195D.3090008@gmail.com>
Date: Mon, 25 May 2009 14:10:52 +0800
Message-ID: <81f0d9c0905242310m215e6e33ia1e0f3be5ec5f147@mail.gmail.com>
Subject: Re: Service Rankings
From: Stuart McCulloch <mcculls@gmail.com>
To: dev@felix.apache.org
Content-Type: multipart/alternative; boundary=000e0cd1776aebf42f046ab678a5

--000e0cd1776aebf42f046ab678a5
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

2009/5/25 Jo=E3o Ferreira <jtjeferreira@gmail.com>

> Hi
>
> I think i found a bug with service rankings since the comparator method
> of service reference isn't being called. I placed a breakpoint in the
> method and got no stop.


you'll need to provide more details like which version of Felix you're usin=
g
and
where you're setting the breakpoint (in trunk the ServiceReference.compareT=
o
implementation is actually in ServiceRegistrationImpl.java:452)

also it depends how you're getting the service - if you use the bundle
context
method "getServiceReference(String clazz)" this definitely uses compareTo
- see the "getBestServiceReference" utility method in BundleContextImpl:271

but if you're using a high-level framework like iPOJO then it might be usin=
g
its
own implementation of the ranking algorithm to sort services (the compareTo
method in ServiceReference only appeared in r4.1 of the OSGi spec, before
that the service ordering was defined in the spec but there was no compareT=
o
method defined in the ServiceReference interface)

Could someone confirm this? I'm creating the services with ipojo but i
> dont think thats the prob since the services have the service.ranking
> property set.
>
> Thanks
> Jo=E3o Ferreira
>


--=20
Cheers, Stuart

--000e0cd1776aebf42f046ab678a5--