felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard S. Hall (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FELIX-1131) ServiceReference.isAssignableTo fails when using a factory that can not see the exported class and the bundle exporting the service does not have a direct wire to this class
Date Wed, 13 May 2009 14:27:45 GMT

    [ https://issues.apache.org/jira/browse/FELIX-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708942#action_12708942
] 

Richard S. Hall commented on FELIX-1131:
----------------------------------------

The JavaDoc sort of says the opposite, see #2 below:

"This method performs the following checks:
1 Get the package name from the specified class name.
2 For the bundle that registered the service referenced by this ServiceReference
(registrant bundle); find the source for the package. If no source is
found then return true if the registrant bundle is equal to the specified
bundle; otherwise return false.
3 If the package source of the registrant bundle is equal to the package
source of the specified bundle then return true; otherwise return false."

> ServiceReference.isAssignableTo fails when using a factory that can not see the exported
class and the bundle exporting the service does not have a direct wire to this class
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-1131
>                 URL: https://issues.apache.org/jira/browse/FELIX-1131
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: felix-1.6.0
>            Reporter: Guillaume Nodet
>
>  * bundle A defines an interface R and a class S in different packages, whith S implementing
R
>  * bundle B defines a class T extending S, it has an import statement on S package, but
not on R package
>  * bundle C defines a ServiceFactory that export T service without any import on any
package from R, S, T
> in this case, the line 426 of ServiceRegistrationImpl is executed:
>                        allow = getServiceRegistration().isClassAccessible(requestClass);
> which looks like:
>    protected boolean isClassAccessible(Class clazz)
>    {
>        try
>        {
>            // Try to load from the service object or service factory class.
>            Class sourceClass = (m_factory != null)
>                ? m_factory.getClass() : m_svcObj.getClass();
>            Class targetClass = Util.loadClassUsingClass(sourceClass, clazz.getName());
>            return (targetClass == clazz);
>        }
>        catch (Exception ex)
>        {
>            // Ignore this and return false.
>        }
>        return false;
>    }
> So felix checks if the classloader used to load the factory can also load the interface,
which is not the case in my example.
> So isClassAccessible returns false and the event is not dispatched to the service listener.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message