felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Clement Escoffier (JIRA)" <j...@apache.org>
Subject [jira] Updated: (FELIX-1055) Making FileInstall bundle CDC-1.1/Foundation 1.1 compatible
Date Thu, 23 Apr 2009 18:37:30 GMT

     [ https://issues.apache.org/jira/browse/FELIX-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Clement Escoffier updated FELIX-1055:
-------------------------------------

              Assignee: Clement Escoffier
    Remaining Estimate: 0h
     Original Estimate: 0h

> Making FileInstall bundle CDC-1.1/Foundation 1.1 compatible
> -----------------------------------------------------------
>
>                 Key: FELIX-1055
>                 URL: https://issues.apache.org/jira/browse/FELIX-1055
>             Project: Felix
>          Issue Type: Improvement
>          Components: File Install
>         Environment: All
>            Reporter: Ali Naddaf
>            Assignee: Clement Escoffier
>            Priority: Minor
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> A minor change will make File Install bundle compatible with the CDC-1.1/Foundation-1.1
compatible:
> Index: src/main/java/org/apache/felix/fileinstall/FileInstall.java
> ===================================================================
> --- src/main/java/org/apache/felix/fileinstall/FileInstall.java (revision 761715)
> +++ src/main/java/org/apache/felix/fileinstall/FileInstall.java (working copy)
> @@ -68,7 +68,7 @@
>          Object o = context.getProperty(key);
>          if (o == null)
>          {
> -            o = System.getenv(key.toUpperCase().replaceAll(".", "_"));
> +           o = System.getProperty(key.toUpperCase().replace('.', '_'));
>              if (o == null)
>              {
>                  return;
> ----------------------------------------------------------------------------------------------------------
> The only needed change is in the FileInstall class:
> 1. replacing String.replaceAll(String, String) with String.replace(char, char) (since
replaceAll is not part of that profile and we are only making one char replacement). If a
more robust replaceAll functionality is required, please let me know and I provide a simple
implementation.
> 2. Using System.getProperty(..) instead of System.getenv(...)
> Thanks,

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message