Mailing-List: contact dev-help@felix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@felix.apache.org
Message-ID: <2020637108.1235078161738.JavaMail.jira@brutus>
Date: Thu, 19 Feb 2009 13:16:01 -0800 (PST)
From: "Filippo Diotalevi (JIRA)" <jira@apache.org>
To: dev@felix.apache.org
Subject: [jira] Commented: (FELIX-939) Optimize File Install
In-Reply-To: <53022927.1234548659565.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/FELIX-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675134#action_12675134 ] 

Filippo Diotalevi commented on FELIX-939:
-----------------------------------------

1) Installed FELIX-937-938-939.patch.v2.
2) Started felix, autostarting bundle   "file:bundles/fileinstall.jar"  (opaque URI)
3) fileinstall monitors directory   "bundles"
4) fileinstall tries to reinstall the "fileinstall.jar" in the monitored folder
5) Felix raise the "BundleException: Bundle symbolic name and version are not unique"
6) fileinstall keeps on polling, but ignores the fileinstall.jar in subsequent polls

It works well, +1 from me.

Please commit also FELIX-942_v2.patch .
Once committed, I will volunteer to extend the test suite.

> Optimize File Install
> ---------------------
>
>                 Key: FELIX-939
>                 URL: https://issues.apache.org/jira/browse/FELIX-939
>             Project: Felix
>          Issue Type: Improvement
>         Environment: generic
>            Reporter: Sahoo
>         Attachments: FELIX-937-938-939.patch, FELIX-937-938-939.patch.v2
>
>
> File Install has a dedicated thread for every directory. That thread wakes up periodically and then does the following:
> 1. Iterates over all the bundles by calling context.getBundles
> 2. Finds out all bundles which belong to watchedDir. It starts them.
> 3. Finds if there is any new jar file in the watchedDir. It installs them.
> 4. Finds out if any jar has been deleted from watcheDir. It uninstalls corresponding bundles.
> 5. Finds out if any jar has been modified. It updates the corresponding bundles.
> I think there is some scope for optimization here. Especially step #2 seems redundant if there has been change in the file system. More over, if out of all the bundles in the system, only a few belong to watchedDir, then the current implementation performs poorly. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.