Return-Path: 
 <dev-return-13073-apmail-felix-dev-archive=felix.apache.org@felix.apache.org>
Delivered-To: apmail-felix-dev-archive@www.apache.org
Received: (qmail 79571 invoked from network); 2 Feb 2009 10:06:21 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 2 Feb 2009 10:06:21 -0000
Received: (qmail 4360 invoked by uid 500); 2 Feb 2009 10:06:21 -0000
Delivered-To: apmail-felix-dev-archive@felix.apache.org
Received: (qmail 4327 invoked by uid 500); 2 Feb 2009 10:06:21 -0000
Mailing-List: contact dev-help@felix.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@felix.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@felix.apache.org>
List-Post: <mailto:dev@felix.apache.org>
List-Id: <dev.felix.apache.org>
Reply-To: dev@felix.apache.org
Delivered-To: mailing list dev@felix.apache.org
Received: (qmail 4314 invoked by uid 99); 2 Feb 2009 10:06:21 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Feb 2009 02:06:21 -0800
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Feb 2009 10:06:20 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 5012B234C48D
	for <dev@felix.apache.org>; Mon,  2 Feb 2009 02:06:00 -0800 (PST)
Message-ID: <1635200396.1233569160319.JavaMail.jira@brutus>
Date: Mon, 2 Feb 2009 02:06:00 -0800 (PST)
From: "Peter Kriens (JIRA)" <jira@apache.org>
To: dev@felix.apache.org
Subject: [jira] Resolved: (FELIX-907) Regression in latest BND code: negated
 exports are applied to private packages
In-Reply-To: <1611752204.1233226919742.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org


     [ https://issues.apache.org/jira/browse/FELIX-907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Kriens resolved FELIX-907.
--------------------------------

    Resolution: Fixed

I have fixed this in bnd-310. I have not used the given patch because it did not solve the problem in all cases (as you said). I now do them separately and then add the results. The tricky part was not to mess with the split package detecting logic.

> Regression in latest BND code: negated exports are applied to private packages
> ------------------------------------------------------------------------------
>
>                 Key: FELIX-907
>                 URL: https://issues.apache.org/jira/browse/FELIX-907
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>            Reporter: Stuart McCulloch
>            Assignee: Peter Kriens
>             Fix For: maven-bundle-plugin-1.6.0
>
>         Attachments: FELIX-907-20090129.patch
>
>
> The latest version of the Bnd Tool has a bug where it combines the Export-Package instructions with the Private-Package instructions:
>         all.putAll(replaceWitInstruction(getHeader(EXPORT_PACKAGE),
>                 EXPORT_PACKAGE));
>         all.putAll(replaceWitInstruction(getHeader(PRIVATE_PACKAGE),
>                 PRIVATE_PACKAGE));
> this ordering means that any negated packages in Export-Package are erroneously applied to the list of packages in Private-Package.
> For example, when you have instructions like the following:
>   <Export-Package>!org.foo.internal.*,org.foo.*</Export-Package>
>   <Private-Package>org.foo.internal.*</Private-Package>
> the Bnd Tool will end up excluding the internal packages from the final bundle.
> Reversing the statements to be:
>         all.putAll(replaceWitInstruction(getHeader(PRIVATE_PACKAGE),
>                 PRIVATE_PACKAGE));
>         all.putAll(replaceWitInstruction(getHeader(EXPORT_PACKAGE),
>                 EXPORT_PACKAGE));
> appears to fix the problem, although you could then have problems with negated packages in the Private-Package affecting the Export-Package - but this is less likely.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.