felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Kriens (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FELIX-939) Optimize File Install
Date Fri, 20 Feb 2009 09:59:01 GMT

    [ https://issues.apache.org/jira/browse/FELIX-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675306#action_12675306

Peter Kriens commented on FELIX-939:

As I said in another bug, please do not change the default behavior. I do believe FI should
attempt to start the bundle at each go, I often use this when getting things to work. I incrementally
add/change bundles until it starts working.

I can't see why the #2 case would perform poorly unless you got thousands of bundles? Optimizing
is fine with me as long as the existing behavior does not change.

> Optimize File Install
> ---------------------
>                 Key: FELIX-939
>                 URL: https://issues.apache.org/jira/browse/FELIX-939
>             Project: Felix
>          Issue Type: Improvement
>         Environment: generic
>            Reporter: Sahoo
>         Attachments: FELIX-937-938-939.patch, FELIX-937-938-939.patch.v2
> File Install has a dedicated thread for every directory. That thread wakes up periodically
and then does the following:
> 1. Iterates over all the bundles by calling context.getBundles
> 2. Finds out all bundles which belong to watchedDir. It starts them.
> 3. Finds if there is any new jar file in the watchedDir. It installs them.
> 4. Finds out if any jar has been deleted from watcheDir. It uninstalls corresponding
> 5. Finds out if any jar has been modified. It updates the corresponding bundles.
> I think there is some scope for optimization here. Especially step #2 seems redundant
if there has been change in the file system. More over, if out of all the bundles in the system,
only a few belong to watchedDir, then the current implementation performs poorly. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message