felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sahoo <Sa...@Sun.COM>
Subject Re: Patch for File Install issues #FELIX-937, 938 & 939
Date Thu, 19 Feb 2009 18:39:13 GMT
Filippo Diotalevi wrote:
> On Thu, Feb 19, 2009 at 9:41 AM, Sahoo <Sahoo@sun.com> wrote:
>   
>> I think I have a solution for this. We will check if the URI is hierarchical
>> before using the path component. That will avoid the NPE. To avoid the issue
>> raised in FELIX-937, we shall not attempt to install the bundle again if we
>> get an exception while trying to install for the first time. I will attach a
>> modified patch soon.
>>     
>
> Given all the (interesting, btw) discussions, in my opinion the
> FELIX-939 cumulative patch is ok and can be committed.
>
> When committing, **please** consider committing also FELIX-942 (the
> second patch, felix-942_v2.patch), that is a first attempt to have
> some unit tests in place.
>
>   
I have now uploaded a new patch (FELIX-937-938-939.patch.v2) in 
FELIX-939 which addresses the NPE issue reported by Filippo while trying 
out the earlier patch.
Filippo, would you mind trying out the new patch once? I have done some 
manual testing and it works.

Thanks,
Sahoo

Thanks,
Sahoo

Mime
View raw message