felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Felix Meschberger (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FELIX-714) Needless component reactivation on startup
Date Thu, 05 Feb 2009 12:21:59 GMT

    [ https://issues.apache.org/jira/browse/FELIX-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670732#action_12670732
] 

Felix Meschberger commented on FELIX-714:
-----------------------------------------

Yes, this makes perfect sense, with one caveat: This method may be called with a null argument
if there is no configuration on first startup and if any existing configuration has been deleted.

So, we would have to take care of this situation like this:

   public void reconfigure( Dictionary configuration )
    {
        // (Pierre) ignore initial configuration admin callback if there's not configuration
at all
        if (configuration == null && m_configurationProperties == null) {
            return;
        }
       .... 

WDYT ?

> Needless component reactivation on startup
> ------------------------------------------
>
>                 Key: FELIX-714
>                 URL: https://issues.apache.org/jira/browse/FELIX-714
>             Project: Felix
>          Issue Type: Bug
>    Affects Versions: scr-1.0.0, scr-1.0.2, scr-1.0.4, scr-1.0.6
>            Reporter: Felix Meschberger
>            Priority: Minor
>
> SCR registers a ManagedService on behalf of each component to receive configuration from
the Configuration Admin Service.
> During component activation, SCR executes the following steps:
>   * registers a ManagedService on behalf of the Component
>   * activates the Component
>   * forwards configuration updates to the Component be reactivating it
> If on first component activation, the Configuration Admin Service has not yet updated
the ManagedService the component will actually be activated twice: first without configuration
and the second time with the configuration. If the Configuration Admin Service does not actually
have configuration for the Component, the second activation is not needed and should be prevented.
> See also http://markmail.org/message/64kiv5nah4bc2ys4

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message