Return-Path: Delivered-To: apmail-felix-dev-archive@www.apache.org Received: (qmail 6242 invoked from network); 21 Nov 2008 18:32:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 21 Nov 2008 18:32:37 -0000 Received: (qmail 99950 invoked by uid 500); 21 Nov 2008 18:32:44 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 99887 invoked by uid 500); 21 Nov 2008 18:32:44 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 99709 invoked by uid 99); 21 Nov 2008 18:32:44 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Nov 2008 10:32:44 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Nov 2008 18:31:28 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 51506234C297 for ; Fri, 21 Nov 2008 10:31:44 -0800 (PST) Message-ID: <329339696.1227292304332.JavaMail.jira@brutus> Date: Fri, 21 Nov 2008 10:31:44 -0800 (PST) From: "Richard S. Hall (JIRA)" To: dev@felix.apache.org Subject: [jira] Resolved: (FELIX-820) Throw an exception when starting a fragment bundle In-Reply-To: <558658602.1226962784199.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/FELIX-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard S. Hall resolved FELIX-820. ----------------------------------- Resolution: Fixed I have applied a modified version of the patch; see the svn commit associated with this JIRA issue for the exact changes I made. In short, I modified some of the comments to make them less precise, since it will be difficult to maintain this in the face of change spec section numbers, for example. I also modified some of the "if" conditions to check for ACTIVE state rather than fragments, since this might be more robust in the future if similar exceptions are introduced. Lastly, I thought of a special case that occurs in updateBundle(), where a previously ACTIVE non-fragment bundle is updated to be a fragment bundle. In that case, I mark its persistent state as inactive and log a warning. Walid, please review and close if you are satisfied. Thanks! > Throw an exception when starting a fragment bundle > -------------------------------------------------- > > Key: FELIX-820 > URL: https://issues.apache.org/jira/browse/FELIX-820 > Project: Felix > Issue Type: Sub-task > Components: Framework, Specification compliance > Affects Versions: felix-1.4.0 > Reporter: Richard S. Hall > Assignee: Richard S. Hall > Fix For: felix-1.4.1 > > Attachments: FELIX-820.patch > > > The spec says attempts to start a fragment should result in an exception. Make it so. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.