Return-Path: Delivered-To: apmail-felix-dev-archive@www.apache.org Received: (qmail 44964 invoked from network); 6 Aug 2008 16:41:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Aug 2008 16:41:08 -0000 Received: (qmail 16968 invoked by uid 500); 6 Aug 2008 16:41:05 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 16906 invoked by uid 500); 6 Aug 2008 16:41:05 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 16733 invoked by uid 99); 6 Aug 2008 16:41:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Aug 2008 09:41:04 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Aug 2008 16:40:17 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 81C72234C18F for ; Wed, 6 Aug 2008 09:40:44 -0700 (PDT) Message-ID: <122414473.1218040844530.JavaMail.jira@brutus> Date: Wed, 6 Aug 2008 09:40:44 -0700 (PDT) From: "Dieter Wimberger (JIRA)" To: dev@felix.apache.org Subject: [jira] Closed: (FELIX-586) org.apache.felix.webconsole.internal.compendium.BaseConfigManager.getAttributeDefinitionMap(): implementation does not properly handle Configuration instances of a ManagedServiceFactory In-Reply-To: <2114009815.1212298004927.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/FELIX-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dieter Wimberger closed FELIX-586. ---------------------------------- > org.apache.felix.webconsole.internal.compendium.BaseConfigManager.getAttributeDefinitionMap(): implementation does not properly handle Configuration instances of a ManagedServiceFactory > ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: FELIX-586 > URL: https://issues.apache.org/jira/browse/FELIX-586 > Project: Felix > Issue Type: Bug > Components: Web Console > Reporter: Dieter Wimberger > Attachments: ConfigManagerBase.java.diff > > > The implementation of org.apache.felix.webconsole.internal.compendium.BaseConfigManager.getAttributeDefinitionMap(): does not properly handle Configuration instances of a ManagedServiceFactory. > In fact, if such a Configuration instance is passed in as a parameter, the method will throw an exception, because there is no ObjectClassDefinition available for the instance. > Example: > A Configuration instance for the ManagedServiceFactory "net.wimpi.telnetd.service.TelnetListenerServiceFactory" was created through the ConfigurationAdmin that assigned the pid "net.wimpi.telnetd.service.TelnetListenerServiceFactory-1212198114040-7". Given that the method will try to obtain an ObjectClassDefinition for "net.wimpi.telnetd.service.TelnetListenerServiceFactory-1212198114040-7", an exception will be thrown, because no such OCD is available. > Fix: > The method needs to check if the Configuration instance has a factoryPid assigned, and should use the factoryPid to obtain the ObjectClassDefinition corresponding to the ManagedServiceFactory. > Also observed in revision 662145 SVN repository. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.