Mailing-List: contact dev-help@felix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@felix.apache.org
Received-SPF: pass (athena.apache.org: domain of mcculls@gmail.com designates
 72.14.214.225 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:references:x-google-sender-auth;
        b=tvPZtcZmmPfC015WZIE+cWMm3wDFopm1Vg4Vb9fQzCMxqMOAPrQ0P4T0x1qX3golUvN0IW4Pe/QkgbAG70DZI4e3I8D7vWH6gV+xSd3pMf4cqnilCWdCjMaPliK/oBGF+krNbExKv1QSe9j5/hZ8oNLA7EE7SOGAnBSGr0J9I7Y=
Message-ID: <81f0d9c0803190946pad24808ld3ef379a3a546d23@mail.gmail.com>
Date: Wed, 19 Mar 2008 09:46:41 -0700
From: "Stuart McCulloch" <stuart.mcculloch@jayway.net>
Sender: mcculls@gmail.com
To: dev@felix.apache.org
Subject: Re: Commons Collections bundle not importing
In-Reply-To: <55afdc850803190924m504b07fapc4da6bac05d44216@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_17874_30893031.1205945201788"
References: <55afdc850803190924m504b07fapc4da6bac05d44216@mail.gmail.com>

------=_Part_17874_30893031.1205945201788
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On 19/03/2008, Niall Pemberton <niall.pemberton@gmail.com> wrote:
>
> I was looking at your commons collections bundle here:
>
> http://svn.apache.org/repos/asf/felix/trunk/commons/commons-collections/pom.xml
>
> ...and wondering why theres an instruction to NOT import
> org.apache.commons.colllections.*?
>
> This seems to go against the general advice given here:
>
> "Bnd automatically imports all exports to allow substitutability. If
> you do not do this, you create all kinds of standalone class spaces
> and things will not work together. It is generally bad practice to
> only export a package."
>
> http://felix.markmail.org/message/qp33zosdp43e2vnv
>
> I'm asking this because theres likely to be an OSGi enabled release of
> Collections from Commons soon (3.3) and I'm wondering if theres a good
> reason in this case and whether we should mirror that in commons?


I can't see any reason to exclude those imports myself,
and they seem to have been there from the beginning
(so they haven't been removed in response to a defect)

Carsten, can you confirm this is not actually needed?

Niall
>

-- 
Cheers, Stuart

------=_Part_17874_30893031.1205945201788--