Return-Path: Delivered-To: apmail-felix-dev-archive@www.apache.org Received: (qmail 28761 invoked from network); 24 Jan 2008 19:29:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 24 Jan 2008 19:29:06 -0000 Received: (qmail 57811 invoked by uid 500); 24 Jan 2008 19:28:56 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 57557 invoked by uid 500); 24 Jan 2008 19:28:56 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 57548 invoked by uid 99); 24 Jan 2008 19:28:56 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Jan 2008 11:28:56 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Jan 2008 19:28:42 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id AA17071420E for ; Thu, 24 Jan 2008 11:28:34 -0800 (PST) Message-ID: <13807583.1201202914690.JavaMail.jira@brutus> Date: Thu, 24 Jan 2008 11:28:34 -0800 (PST) From: "Karl Pauls (JIRA)" To: dev@felix.apache.org Subject: [jira] Commented: (FELIX-471) FilterImpl.toString() does not add escape characters In-Reply-To: <199863.1201202434764.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/FELIX-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562177#action_12562177 ] Karl Pauls commented on FELIX-471: ---------------------------------- Good catch. This will make it into 1.0.2. Thanks. > FilterImpl.toString() does not add escape characters > ---------------------------------------------------- > > Key: FELIX-471 > URL: https://issues.apache.org/jira/browse/FELIX-471 > Project: Felix > Issue Type: Bug > Components: Framework > Reporter: Angelo van der Sijpt > Assignee: Karl Pauls > Attachments: FELIX-471.patch > > > FilterImpl.toString() is not a complete representation of the filter string that was used to create it: four characters ( '(', ')', '/' and '*' ) should be preceded by a '\' if they are to be used in a value. > For example, > new FilterImpl("(b=\(*)").toString(); > should return '(b=\(*)', but it returns '(b=(*)'. So, it can happen that a correct Filter f, when used in > new FilterImpl(f.toString()); > causes an InvalidSyntaxException. > (see http://www2.osgi.org/javadoc/r4/org/osgi/framework/Filter.html#toString() for what toString() should do). > See the attached patch for a proposed solution. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.