felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton" <niall.pember...@gmail.com>
Subject Re: Commons FileUpload 1.2.1 & OSGi
Date Wed, 16 Jan 2008 10:34:19 GMT
Felix, Carsten,

Thanks for the feedback - I've changed as you suggested to use dynamic import:
http://svn.apache.org/viewvc?view=rev&revision=612412

New copy of the manifest here:
http://people.apache.org/~niallp/commons-osgi/commons-fileupload-1.2.1-MANIFEST.MF-v2.txt

Niall

On Jan 16, 2008 8:09 AM, Carsten Ziegeler <cziegeler@apache.org> wrote:
> Felix Meschberger wrote:
> > Hi Niall,
> >
> > To me the manifest looks good, except perhaps for the import of the
> > javax.portlet package: I fear, not all servlet containers have this
> > package, so it might be a good idea to either import it dynamically or
> > optional:
> >
> >    Dynamic import:
> >
> >          <DynamicImport-Package>javax.portlet</DynamicImport-Package>
> >
> >    Optional import:
> >
> >          <Import-Package>
> >             ...,
> >             javax.portlet;resolution:=optional,
> >             ...
> >          </Import-Package>
> >
> > The advantage of the dynamic resolution is that, it may get
> > automatically resolved as soon as the javax.portlet package gets
> > available and will be required the first time. The optional import will
> > only be tried to be resolved at bundle resolution time and will not be
> > retried unless the bundle is resolved again.
> >
> Yes, I think using the DynamicImport-Package is the better option.
>
> Carsten
>
>
> > WDYT ?
> >
> > Thanks and Regards
> > Felix
> >
> >
> > Am Dienstag, den 15.01.2008, 23:07 +0000 schrieb Niall Pemberton:
> >> Hi Carsten,
> >>
> >> The vote on Commons FileUpload 1.2.1 has problems and it seems likely
> >> that there will be a new RC since the issues are resolved by the
> >> latest release of our parent pom. I've added OSGi parameters to its
> >> pom in case the RM does cut another RC:
> >>
> >> http://svn.apache.org/viewvc?view=rev&revision=612269
> >>
> >>  I've built the jar and it and the manifest generated are here:
> >>
> >>    http://people.apache.org/~niallp/commons-osgi/
> >>
> >> Don't know if you (or anyone else) have time to review to make sure I
> >> haven't screwed up, plus it may not get into the release anyway and be
> >> a waste of your time. But I thought I would try...
> >>
> >> Niall
> >
> >
>
>
> --
> Carsten Ziegeler
> cziegeler@apache.org
>

Mime
View raw message