Return-Path: Delivered-To: apmail-felix-dev-archive@www.apache.org Received: (qmail 96747 invoked from network); 17 Dec 2007 16:45:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Dec 2007 16:45:13 -0000 Received: (qmail 49074 invoked by uid 500); 17 Dec 2007 16:45:02 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 49045 invoked by uid 500); 17 Dec 2007 16:45:02 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 49036 invoked by uid 99); 17 Dec 2007 16:45:02 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Dec 2007 08:45:02 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 17 Dec 2007 16:44:58 +0000 Received: (qmail 96684 invoked from network); 17 Dec 2007 16:44:49 -0000 Received: from localhost (HELO ?127.0.0.1?) (127.0.0.1) by localhost with SMTP; 17 Dec 2007 16:44:49 -0000 Message-ID: <4766A780.1000802@apache.org> Date: Mon, 17 Dec 2007 17:44:48 +0100 From: Carsten Ziegeler User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031) MIME-Version: 1.0 To: dev@felix.apache.org Subject: Re: svn commit: r604816 - /felix/trunk/main/src/main/java/org/apache/felix/main/Main.java References: <20071217103010.055D51A984E@eris.apache.org> <20071217105022.a3557530.heavy@ungoverned.org> In-Reply-To: <20071217105022.a3557530.heavy@ungoverned.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Richard S. Hall wrote: > On Mon, 17 Dec 2007 10:30:09 -0000 > cziegeler@apache.org wrote: > > Our coding style guide says that we do not list all imported packages after exceeding a "readability limit"...I am not sure what the readability limit is, but for me in Eclipse I set it to 3 references beforing going to "*"...does anyone know if it is possible to set this limit in NetBeans? > > At any rate, do we need to be more specific in our coding style guide? > Yes :) This is something I wanted to address but totally forgot about it. Sorry for first committing. I think we should always list all imports - the readability limit is in most cases more or less useless. If you import from a lot of packages it doesn't help anyway (now we could argue if importing from a dozen packages is a good thing, but thats a different story). And if you want to see what a class is exactly using, a complete list of all imports is much more helpful. Modern ides can hide all imports in the editor anyway. Carsten -- Carsten Ziegeler cziegeler@apache.org