Return-Path: Delivered-To: apmail-felix-dev-archive@www.apache.org Received: (qmail 30966 invoked from network); 22 Aug 2007 14:38:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 22 Aug 2007 14:38:53 -0000 Received: (qmail 91947 invoked by uid 500); 22 Aug 2007 14:38:49 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 91926 invoked by uid 500); 22 Aug 2007 14:38:49 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 91917 invoked by uid 99); 22 Aug 2007 14:38:49 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Aug 2007 07:38:49 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Aug 2007 14:38:51 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 6B373714212 for ; Wed, 22 Aug 2007 07:38:31 -0700 (PDT) Message-ID: <14703895.1187793511435.JavaMail.jira@brutus> Date: Wed, 22 Aug 2007 07:38:31 -0700 (PDT) From: "Richard S. Hall (JIRA)" To: dev@felix.apache.org Subject: [jira] Commented: (FELIX-343) Add "additional-Resource" option In-Reply-To: <19729224.1187787750526.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/FELIX-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521805 ] Richard S. Hall commented on FELIX-343: --------------------------------------- I guess that makes more sense, but it ultimately sounds like a shortcoming of Maven in general, because if you have all of these plugins adding different defaults to the resource paths and at some point you decide to specify your own resource to include, then you will then lose all of the defaults added by these plugins. To really resolve your use-case, bundles should never use Include-Resource and only use additional-Resource so that they always get the default values, otherwise they will have to know all of the defaults of every plugin they use. Include-Resource should only be used if you know for a fact that you want to override every potential default of every plugin you use. Seems sort of sucky. > Add "additional-Resource" option > -------------------------------- > > Key: FELIX-343 > URL: https://issues.apache.org/jira/browse/FELIX-343 > Project: Felix > Issue Type: Improvement > Components: Maven Bundle Plugin > Affects Versions: 1.0.0 > Reporter: Carsten Ziegeler > Attachments: patch.txt > > > The "Include-Resource" option is currently a all-or-nothing option which is directly forwarded to bnd. One can either use the default (the maven resource paths) or specify the whole paths oneself. In many cases it is more desirable to just provide additional paths to the default maven paths. > Therefore I created a patch which adds an "addtional-Resource" property. The logic is as follows: > - If Include-Resource is specified but no additional-Resource: Include-Resource is forwarded to bnd > - If Include-Resource is specified and additional-Resource: Include-Resource+','+additionalResource is forwarded to bnd > - if no Include-Resource is specified and no additional-Resource: maven resource paths are forwarded to bnd > - if no Include-Resource is specified and additional-Resource is given: maven resource paths + additionalResource are forwarded to bnd. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.