felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard S. Hall (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FELIX-343) Add "additional-Resource" option
Date Wed, 22 Aug 2007 15:08:30 GMT

    [ https://issues.apache.org/jira/browse/FELIX-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521816

Richard S. Hall commented on FELIX-343:

Stuart, the same idea crossed my mind, but in the end, I still think it all sounds sucky because
there is this underlying assumption that the bundle developer is aware of all of these hidden
defaults and can make intelligent decisions about whether or not to override them.

Regardless, if we are going to do it, I am more in favor modifying Include-Resource to support
it, rather than adding another property. You could just embed the flag right into the Include-Resource
property, like:


Then the plugin could expand the default resources when present before passing it to BND.
At least this makes it explicit and somewhat obvious what is going on. However, I don't want
to sound like I like this idea. I think it is a band-aid on an ugly issue.

> Add "additional-Resource" option
> --------------------------------
>                 Key: FELIX-343
>                 URL: https://issues.apache.org/jira/browse/FELIX-343
>             Project: Felix
>          Issue Type: Improvement
>          Components: Maven Bundle Plugin
>    Affects Versions: 1.0.0
>            Reporter: Carsten Ziegeler
>         Attachments: patch.txt
> The "Include-Resource" option is currently a all-or-nothing option which is directly
forwarded to bnd. One can either use the default (the maven resource paths) or specify the
whole paths oneself. In many cases it is more desirable to just provide additional paths to
the default maven paths.
> Therefore I created a patch which adds an "addtional-Resource" property. The logic is
as follows:
> - If Include-Resource is specified but no additional-Resource: Include-Resource is forwarded
to bnd
> - If Include-Resource is specified and additional-Resource: Include-Resource+','+additionalResource
is forwarded to bnd
> - if no Include-Resource is specified and no additional-Resource: maven resource paths
are forwarded to bnd
> - if no Include-Resource is specified and additional-Resource is given: maven resource
paths + additionalResource are forwarded to bnd.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message