felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard S. Hall (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FELIX-324) Framework constructor should take a non-mutable property resolver
Date Wed, 11 Jul 2007 19:03:04 GMT

    [ https://issues.apache.org/jira/browse/FELIX-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511828

Richard S. Hall commented on FELIX-324:

On second thought, after talking with Karl, he likes the fact that it is possible to externally
change bundle configuration properties by not copying the passed in set of properties (which
would be required to actually make it immutable). Therefore, we won't change this to accept
a property resolver.

However, in an effort to clean up the API, I think we can at least eliminate the PropertyResolver
classes and just use Map directly, since the PropertyResolver interface doesn't really buy
us anything (especially since it normally just wraps a map anyway) and it is just more API
for someone else to learn.

I will commit changes converting PropertyResolver to Map shortly...

> Framework constructor should take a non-mutable property resolver
> -----------------------------------------------------------------
>                 Key: FELIX-324
>                 URL: https://issues.apache.org/jira/browse/FELIX-324
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 1.0.0
>            Reporter: Richard S. Hall
>            Assignee: Richard S. Hall
>             Fix For: 1.0.0
> As part of our effort to improve Felix' public API for the 1.0.0 release, I think we
should probably change the constructor to take a PropertyResolver instead of a MutablePropertyResolver.
I believe the original choice of MutablePropertyResolver was to avoid having to copy the passed
in configuration properties, but it is probably safer if the framework makes its own copy,
which will prevent attempts to externally modify the configuration properties at run time.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message