Mailing-List: contact felix-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: felix-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: domain of fmeschbe@gmail.com designates
 64.233.162.206 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
        b=hFHhrbK1bEZRSZIkZj8RTtdowfxUrJE0GvfEEjsGuQrdFD+y/e5StpAlEPxza7rU1r1D7HQA+hdW/StWhMJU9+CrALKwDKp7Aa1F1X/7QmLRQm7ltXPvFvepnAA0c9o6AMaWoicd8rLI02DuwAWcgROS61ohkUC5KKPqbHcdODo=
Message-ID: <ae03024e0611070558w366ac27ei959f2b36b1d31fd3@mail.gmail.com>
Date: Tue, 7 Nov 2006 14:58:29 +0100
From: "Felix Meschberger" <Felix.Meschberger@day.com>
Sender: fmeschbe@gmail.com
To: felix-dev@incubator.apache.org
Subject: Re: [jira] Commented: (FELIXM2-10) maven-bundle-plugin: Failures if
 src or parts of it are missing
In-Reply-To: <45503CBE.1050006@ungoverned.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <32937868.1162884410656.JavaMail.jira@brutus>
	 <45503CBE.1050006@ungoverned.org>

Hi Richard,

> By including it, all resources will be copied into the resulting JAR
> file as expected. Perhaps what we need to do is have the plugin
> automatically convert any resources listed in the POM to the
> Include-Resource instruction, as you basically suggested...

I agree, that it might be burden to the developper to have to think
about not forgetting to include the resources through Private-Package
declarations. And mabe it is just simpler to do it this way.

On the other hand, I assume that 99% of the projects do not specify
resources other than the default and most of the time those should be
copied. Hence, it might as well be left as is. And hanlding "missing
resources" is fixed, so we might just go ahead :-)

Regards
Felix

>
> -> richard
>
> >
> >> maven-bundle-plugin: Failures if src or parts of it are missing
> >> ---------------------------------------------------------------
> >>
> >>                 Key: FELIXM2-10
> >>                 URL: http://issues.apache.org/jira/browse/FELIXM2-10
> >>             Project: Felix M2 Plugin
> >>          Issue Type: Bug
> >>            Reporter: Felix Meschberger
> >>         Assigned To: Richard S. Hall
> >>         Attachments: FELIXM2-10.diff
> >>
> >>
> >> When using the maven-bundle-plugin to build bundles from existing jar files, three issues exist:
> >>    * If nothing is copied into the project output directory (target/classes), the folder does not exist and the BundlePlugin.getClassPath fails for the line "new Jar(".", outputDirectory)"
> >>    * If no resources exist, an exception is logged for the missing src/main/resources folder. I suggest to only place a default Include-Resources header if the src/main/resources folder exists.
> >>    * If no maven build phase generates output the target folder does not exist at the time the BundlePluing.execute method tries to write the JAR File.
> >> I will attach a patch for the three issues.
> >>
> >
> >
>