felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BJ Hargrave <hargr...@us.ibm.com>
Subject Re: [jira] Updated: (FELIX-22) Implement support for digitally signed bundles
Date Mon, 28 Aug 2006 20:01:06 GMT
"Karl Pauls" <karlpauls@gmail.com> wrote on 08/28/2006 03:38:30 PM:

> Hello,
> 
> first of all, thanks a lot for reviewing the patch.
> 
> Second, a question in regard to 1) if I may.
> Why is it improper to use an inner class for the 
AdminPermissionCollection?

Well it could be an non-member inner class (i.e. "static class"). But to 
be an member inner class means it holds an implicit reference to a single 
AdminPermission object which is wrong for a PermissionCollection. 
Typically these PermissionCollection subclasses are top level, package 
private classes held in the same .java file as the Permission subclass 
they collect. See org.osgi.framework.PackagePermission for an example.

> 
> In regard to number 2), the Signer class needs to be moved out of
> AdminPermission, due to being used by the BundleSignerCondition of
> ConditionalPermissionAdmin, eventually. However, I need a bit more
> time to get to that point (and to find a good place too).

Sure. As long as the public signature of the OSGi classes are unaltered 
when you are all finished.

> 
> regards,
> 
> Karl


BJ Hargrave
Senior Technical Staff Member, IBM
OSGi Fellow and CTO of the OSGi Alliance
hargrave@us.ibm.com
Office: +1 407 849 9117 Mobile: +1 386 848 3788


Mime
View raw message