felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Pauls" <karlpa...@gmail.com>
Subject Re: [jira] Updated: (FELIX-26) Improve native library matching algorithm
Date Wed, 30 Aug 2006 10:15:15 GMT
> It's not a problem for me to give a svn diff file, and all compete modified
> sources. Just a matter of organization.

Thanks for doing this. While it is certainly possible to workaround a
missing patch its way more work on the reviewers site hence, by
providing a patch in the first place you provide for quicker response.

> What's important now, is to know wether my patch will increase the amazing
> Felix score against OSGi's TCK :-)

Well, one thing I noticed while looking at your patch is that you are
using java.util.regex*. That part will not make it into the core
because java.util.regex is not available in all of the environments we
target.

In other words, if you want to foster your case further it might be
helpful to give the patch some more work and get rid of the
java.util.regex dependency...

> --
> </arnaud>

regards,

Karl

-- 
Karl Pauls
karlpauls@gmail.com

Mime
View raw message