felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Pauls" <karlpa...@gmail.com>
Subject Re: [jira] Updated: (FELIX-22) Implement support for digitally signed bundles
Date Mon, 28 Aug 2006 19:38:30 GMT
Hello,

first of all, thanks a lot for reviewing the patch.

Second, a question in regard to 1) if I may.
Why is it improper to use an inner class for the AdminPermissionCollection?

In regard to number 2), the Signer class needs to be moved out of
AdminPermission, due to being used by the BundleSignerCondition of
ConditionalPermissionAdmin, eventually. However, I need a bit more
time to get to that point (and to find a good place too).

regards,

Karl

> BJ Hargrave updated FELIX-22:
> -----------------------------
>
>     Attachment: patch.txt
>
> The current implementation of org.osgi.framework.AdminPermission has 2 flaws.
>
> 1) The AdminPermissionCollection class is improperly an inner class. It should be a top
level, package private class (or at least a non-member inner class, e.g. static).
>
> 2) The inner class Signer is public and thus alters the public signature of the org.osgi.framework
package in violation of the OSGi spec.
>
> The attached patch solves both issues.
>
> > Implement support for digitally signed bundles
> > ----------------------------------------------
> >
> >                 Key: FELIX-22
> >                 URL: http://issues.apache.org/jira/browse/FELIX-22
> >             Project: Felix
> >          Issue Type: New Feature
> >          Components: Specification compliance, Framework
> >            Reporter: Richard S. Hall
> >         Assigned To: Karl Pauls
> >         Attachments: patch.txt
> >
> >
> > This issue relates to section 2 of the OSGi R4 specification. This issue is somewhat
difficult in general, but even more difficult if we hope to create a solution that works easily
on J2ME and constrained devices.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>


-- 
Karl Pauls
karlpauls@gmail.com

Mime
View raw message