Mailing-List: contact commits-help@felix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@felix.apache.org
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r1717205 - in
 /felix/trunk/webconsole-plugins/script-console/src/test/java/org/apache/felix/webconsole/plugins/scriptconsole/internal:
 ./ ScriptEngineManagerTest.java
Date: Mon, 30 Nov 2015 09:00:41 -0000
To: commits@felix.apache.org
From: chetanm@apache.org
Message-Id: <20151130090041.C79073A0234@svn01-us-west.apache.org>

Author: chetanm
Date: Mon Nov 30 09:00:41 2015
New Revision: 1717205

URL: http://svn.apache.org/viewvc?rev=1717205&view=rev
Log:
FELIX-5120 - ScriptEngineManager not able to parse service file with comments at end of classname

Add a failing testcase

Added:
    felix/trunk/webconsole-plugins/script-console/src/test/java/org/apache/felix/webconsole/plugins/scriptconsole/internal/
    felix/trunk/webconsole-plugins/script-console/src/test/java/org/apache/felix/webconsole/plugins/scriptconsole/internal/ScriptEngineManagerTest.java   (with props)

Added: felix/trunk/webconsole-plugins/script-console/src/test/java/org/apache/felix/webconsole/plugins/scriptconsole/internal/ScriptEngineManagerTest.java
URL: http://svn.apache.org/viewvc/felix/trunk/webconsole-plugins/script-console/src/test/java/org/apache/felix/webconsole/plugins/scriptconsole/internal/ScriptEngineManagerTest.java?rev=1717205&view=auto
==============================================================================
--- felix/trunk/webconsole-plugins/script-console/src/test/java/org/apache/felix/webconsole/plugins/scriptconsole/internal/ScriptEngineManagerTest.java (added)
+++ felix/trunk/webconsole-plugins/script-console/src/test/java/org/apache/felix/webconsole/plugins/scriptconsole/internal/ScriptEngineManagerTest.java Mon Nov 30 09:00:41 2015
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.felix.webconsole.plugins.scriptconsole.internal;
+
+import java.io.BufferedReader;
+import java.io.StringReader;
+import java.util.List;
+
+import org.junit.Ignore;
+import org.junit.Test;
+
+import static java.util.Arrays.asList;
+import static org.junit.Assert.assertEquals;
+
+public class ScriptEngineManagerTest {
+
+    @Test
+    public void simpleConfig() throws Exception
+    {
+        String config = "org.codehaus.groovy.jsr223.GroovyScriptEngineFactory\n";
+        List<String> classNames = ScriptEngineManager.getClassNames(new BufferedReader(new StringReader(config)));
+        assertEquals(asList("org.codehaus.groovy.jsr223.GroovyScriptEngineFactory"),classNames);
+    }
+
+    @Test
+    public void configWithComment() throws Exception
+    {
+        String config = "#Groovy Script Support\n" +
+                "\n" +
+                "org.codehaus.groovy.jsr223.GroovyScriptEngineFactory";
+        List<String> classNames = ScriptEngineManager.getClassNames(new BufferedReader(new StringReader(config)));
+        assertEquals(asList("org.codehaus.groovy.jsr223.GroovyScriptEngineFactory"),classNames);
+    }
+
+    @Ignore("FELIX-5120")
+    @Test
+    public void configWithCommentAtEnd() throws Exception
+    {
+        String config = "\n" +
+                "#script engines supported\n" +
+                "\n" +
+                "com.sun.script.javascript.RhinoScriptEngineFactory #javascript\n" +
+                "\n";
+        List<String> classNames = ScriptEngineManager.getClassNames(new BufferedReader(new StringReader(config)));
+        assertEquals(asList("com.sun.script.javascript.RhinoScriptEngineFactory"),classNames);
+
+    }
+}

Propchange: felix/trunk/webconsole-plugins/script-console/src/test/java/org/apache/felix/webconsole/plugins/scriptconsole/internal/ScriptEngineManagerTest.java
------------------------------------------------------------------------------
    svn:eol-style = native