Return-Path: X-Original-To: apmail-felix-commits-archive@www.apache.org Delivered-To: apmail-felix-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8702B10930 for ; Fri, 5 Dec 2014 08:20:21 +0000 (UTC) Received: (qmail 70598 invoked by uid 500); 5 Dec 2014 08:20:21 -0000 Delivered-To: apmail-felix-commits-archive@felix.apache.org Received: (qmail 70558 invoked by uid 500); 5 Dec 2014 08:20:21 -0000 Mailing-List: contact commits-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list commits@felix.apache.org Received: (qmail 70547 invoked by uid 99); 5 Dec 2014 08:20:21 -0000 Received: from hades.apache.org (HELO hades.apache.org) (140.211.11.105) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Dec 2014 08:20:21 +0000 Received: from hades.apache.org (localhost [127.0.0.1]) by hades.apache.org (ASF Mail Server at hades.apache.org) with ESMTP id 74B73AC0790; Fri, 5 Dec 2014 08:20:18 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1643185 - /felix/trunk/ipojo/runtime/core/src/main/java/org/apache/felix/ipojo/InstanceManager.java Date: Fri, 05 Dec 2014 08:20:18 -0000 To: commits@felix.apache.org From: clement@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20141205082019.74B73AC0790@hades.apache.org> Author: clement Date: Fri Dec 5 08:20:18 2014 New Revision: 1643185 URL: http://svn.apache.org/viewvc?rev=1643185&view=rev Log: Fix FELIX-4455 by providing a better error message Modified: felix/trunk/ipojo/runtime/core/src/main/java/org/apache/felix/ipojo/InstanceManager.java Modified: felix/trunk/ipojo/runtime/core/src/main/java/org/apache/felix/ipojo/InstanceManager.java URL: http://svn.apache.org/viewvc/felix/trunk/ipojo/runtime/core/src/main/java/org/apache/felix/ipojo/InstanceManager.java?rev=1643185&r1=1643184&r2=1643185&view=diff ============================================================================== --- felix/trunk/ipojo/runtime/core/src/main/java/org/apache/felix/ipojo/InstanceManager.java (original) +++ felix/trunk/ipojo/runtime/core/src/main/java/org/apache/felix/ipojo/InstanceManager.java Fri Dec 5 08:20:18 2014 @@ -793,8 +793,10 @@ public class InstanceManager implements stop(); throw new RuntimeException("Cannot create a POJO instance, the POJO constructor has thrown an exception", e.getTargetException()); } catch (NoSuchMethodException e) { + // Improve the log message because of FELIX-4455, we will see if we get better feedback. m_logger.log(Logger.ERROR, - "[" + m_name + "] createInstance -> Cannot invoke the constructor (method not found) : " + e.getMessage(), e); + "[" + m_name + "] iPOJO did not find a suitable constructor to create the " + + "object: " + e.getMessage(), e); stop(); throw new RuntimeException("Cannot create a POJO instance, the POJO constructor cannot be found", e); } catch (Throwable e) {