Return-Path: X-Original-To: apmail-felix-commits-archive@www.apache.org Delivered-To: apmail-felix-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 62092C6D8 for ; Mon, 24 Nov 2014 00:03:35 +0000 (UTC) Received: (qmail 433 invoked by uid 500); 24 Nov 2014 00:03:35 -0000 Delivered-To: apmail-felix-commits-archive@felix.apache.org Received: (qmail 389 invoked by uid 500); 24 Nov 2014 00:03:35 -0000 Mailing-List: contact commits-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list commits@felix.apache.org Received: (qmail 379 invoked by uid 99); 24 Nov 2014 00:03:35 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Nov 2014 00:03:35 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Nov 2014 00:03:34 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 02B8D238899C; Mon, 24 Nov 2014 00:02:44 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1641298 - /felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/ComponentImpl.java Date: Mon, 24 Nov 2014 00:02:43 -0000 To: commits@felix.apache.org From: pderop@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20141124000244.02B8D238899C@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: pderop Date: Mon Nov 24 00:02:43 2014 New Revision: 1641298 URL: http://svn.apache.org/r1641298 Log: fixed some comments Modified: felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/ComponentImpl.java Modified: felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/ComponentImpl.java URL: http://svn.apache.org/viewvc/felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/ComponentImpl.java?rev=1641298&r1=1641297&r2=1641298&view=diff ============================================================================== --- felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/ComponentImpl.java (original) +++ felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/ComponentImpl.java Mon Nov 24 00:02:43 2014 @@ -249,12 +249,11 @@ public class ComponentImpl implements Co if (m_bundle == null /* only in tests env */ || m_bundle.getState() == Bundle.ACTIVE) { executor.execute(stopTask); // asynchronous if we are using a DispatchExecutor and a threadpool. } else { - // If the component bundle is stopping, not active, we want to deactive the component synchronously - // because if not, we would end up in a situation with all sort of problems. - + // If the component bundle is stopping, not active, we want to ensures that the component is + // removed (stopped) before the bundle is invalidated. if (executor instanceof SerialExecutor) { // Most of the time, the stopTask will be called synchronously. But in rare occasions, if the - // SerialExecutor is busy and being handling an event in another thread, then in this case + // SerialExecutor is busy and handling an event in another thread, then in this case // the stopTask will be executed asynchronously ... but our latch will make sure we wait for the // component deactivation. executor.execute(stopTask);