felix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pde...@apache.org
Subject svn commit: r1641298 - /felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/ComponentImpl.java
Date Mon, 24 Nov 2014 00:02:43 GMT
Author: pderop
Date: Mon Nov 24 00:02:43 2014
New Revision: 1641298

URL: http://svn.apache.org/r1641298
Log:
fixed some comments

Modified:
    felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/ComponentImpl.java

Modified: felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/ComponentImpl.java
URL: http://svn.apache.org/viewvc/felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/ComponentImpl.java?rev=1641298&r1=1641297&r2=1641298&view=diff
==============================================================================
--- felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/ComponentImpl.java
(original)
+++ felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/ComponentImpl.java
Mon Nov 24 00:02:43 2014
@@ -249,12 +249,11 @@ public class ComponentImpl implements Co
             if (m_bundle == null /* only in tests env */ || m_bundle.getState() == Bundle.ACTIVE)
{
                 executor.execute(stopTask); // asynchronous if we are using a DispatchExecutor
and a threadpool.
             } else {
-                // If the component bundle is stopping, not active, we want to deactive the
component synchronously
-                // because if not, we would end up in a situation with all sort of problems.
-                
+                // If the component bundle is stopping, not active, we want to ensures that
the component is
+                // removed (stopped) before the bundle is invalidated.                
                 if (executor instanceof SerialExecutor) {
                     // Most of the time, the stopTask will be called synchronously. But in
rare occasions, if the 
-                    // SerialExecutor is busy and being handling an event in another thread,
then in this case
+                    // SerialExecutor is busy and handling an event in another thread, then
in this case
                     // the stopTask will be executed asynchronously ... but our latch will
make sure we wait for the 
                     // component deactivation.
                     executor.execute(stopTask);



Mime
View raw message