Return-Path: X-Original-To: apmail-felix-commits-archive@www.apache.org Delivered-To: apmail-felix-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D95E211539 for ; Mon, 28 Jul 2014 12:47:56 +0000 (UTC) Received: (qmail 52889 invoked by uid 500); 28 Jul 2014 12:47:56 -0000 Delivered-To: apmail-felix-commits-archive@felix.apache.org Received: (qmail 52842 invoked by uid 500); 28 Jul 2014 12:47:56 -0000 Mailing-List: contact commits-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list commits@felix.apache.org Received: (qmail 52833 invoked by uid 99); 28 Jul 2014 12:47:56 -0000 Received: from Unknown (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Jul 2014 12:47:56 +0000 X-ASF-Spam-Status: No, hits=-1997.7 required=5.0 tests=ALL_TRUSTED,SUBJECT_DRUG_GAP_L X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Jul 2014 12:47:52 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id DA7CE238896F; Mon, 28 Jul 2014 12:47:27 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1613989 - /felix/trunk/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java Date: Mon, 28 Jul 2014 12:47:27 -0000 To: commits@felix.apache.org From: cziegeler@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20140728124727.DA7CE238896F@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: cziegeler Date: Mon Jul 28 12:47:27 2014 New Revision: 1613989 URL: http://svn.apache.org/r1613989 Log: FELIX-4586 : A field must be volatile if methods are generated for a dynamic reference Modified: felix/trunk/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java Modified: felix/trunk/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java URL: http://svn.apache.org/viewvc/felix/trunk/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java?rev=1613989&r1=1613988&r2=1613989&view=diff ============================================================================== --- felix/trunk/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java (original) +++ felix/trunk/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java Mon Jul 28 12:47:27 2014 @@ -503,11 +503,6 @@ public class Validator { if (!fieldIsVolatile) { this.logError(ref, "Dynamic field must be declared volatile for unary references"); } - } else { - // field should be volatile - if (!fieldIsVolatile) { - this.logError(ref, "Dynamic field should be declared volatile for unary references"); - } } } }