felix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cziege...@apache.org
Subject svn commit: r1613989 - /felix/trunk/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java
Date Mon, 28 Jul 2014 12:47:27 GMT
Author: cziegeler
Date: Mon Jul 28 12:47:27 2014
New Revision: 1613989

URL: http://svn.apache.org/r1613989
Log:
FELIX-4586 : A field must be volatile if methods are generated for a dynamic reference

Modified:
    felix/trunk/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java

Modified: felix/trunk/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java
URL: http://svn.apache.org/viewvc/felix/trunk/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java?rev=1613989&r1=1613988&r2=1613989&view=diff
==============================================================================
--- felix/trunk/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java
(original)
+++ felix/trunk/scrplugin/generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java
Mon Jul 28 12:47:27 2014
@@ -503,11 +503,6 @@ public class Validator {
                             if (!fieldIsVolatile) {
                                 this.logError(ref, "Dynamic field must be declared volatile
for unary references");
                             }
-                        } else {
-                            // field should be volatile
-                            if (!fieldIsVolatile) {
-                                this.logError(ref, "Dynamic field should be declared volatile
for unary references");
-                            }
                         }
                     }
                 }



Mime
View raw message