felix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pde...@apache.org
Subject svn commit: r1558966 - /felix/trunk/dependencymanager/test/src/test/java/org/apache/felix/dm/test/integration/api/ServiceRaceTest.java
Date Fri, 17 Jan 2014 00:25:59 GMT
Author: pderop
Date: Fri Jan 17 00:25:58 2014
New Revision: 1558966

URL: http://svn.apache.org/r1558966
Log:
don't clone the configuration passed to the ASpect.updated method

Modified:
    felix/trunk/dependencymanager/test/src/test/java/org/apache/felix/dm/test/integration/api/ServiceRaceTest.java

Modified: felix/trunk/dependencymanager/test/src/test/java/org/apache/felix/dm/test/integration/api/ServiceRaceTest.java
URL: http://svn.apache.org/viewvc/felix/trunk/dependencymanager/test/src/test/java/org/apache/felix/dm/test/integration/api/ServiceRaceTest.java?rev=1558966&r1=1558965&r2=1558966&view=diff
==============================================================================
--- felix/trunk/dependencymanager/test/src/test/java/org/apache/felix/dm/test/integration/api/ServiceRaceTest.java
(original)
+++ felix/trunk/dependencymanager/test/src/test/java/org/apache/felix/dm/test/integration/api/ServiceRaceTest.java
Fri Jan 17 00:25:58 2014
@@ -344,7 +344,7 @@ public class ServiceRaceTest extends Tes
         volatile S m_next;
         final String m_name;
         final Ensure m_invoked, m_started, m_stopped, m_updated;
-        volatile Map<String, String> m_conf;
+        volatile Dictionary<String, String> m_conf;
 
         SAspect(Ensure started, Ensure stopped, Ensure updated, Ensure invoked, String name)
{
             m_started = started;
@@ -360,12 +360,7 @@ public class ServiceRaceTest extends Tes
                 return;
             }
             debug("Aspect %s injected with configuration: %s", this, conf);
-            Map<String, String> copy = new HashMap<String, String>();
-            for (String key : Collections.list(conf.keys()))
-            {
-                copy.put(key, conf.get(key));
-            }
-            m_conf = copy;
+            m_conf = conf;
             m_updated.step();
         }
 



Mime
View raw message