Return-Path: X-Original-To: apmail-felix-commits-archive@www.apache.org Delivered-To: apmail-felix-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A68F4F316 for ; Wed, 29 May 2013 11:49:06 +0000 (UTC) Received: (qmail 60422 invoked by uid 500); 29 May 2013 11:49:06 -0000 Delivered-To: apmail-felix-commits-archive@felix.apache.org Received: (qmail 60220 invoked by uid 500); 29 May 2013 11:49:01 -0000 Mailing-List: contact commits-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list commits@felix.apache.org Received: (qmail 59529 invoked by uid 99); 29 May 2013 11:48:59 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 May 2013 11:48:59 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 May 2013 11:48:58 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 16F0D2388906; Wed, 29 May 2013 11:48:39 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1487443 - /felix/trunk/ipojo/runtime/core/src/main/java/org/apache/felix/ipojo/extender/internal/processor/ExtensionBundleProcessor.java Date: Wed, 29 May 2013 11:48:39 -0000 To: commits@felix.apache.org From: guillaume@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20130529114839.16F0D2388906@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: guillaume Date: Wed May 29 11:48:38 2013 New Revision: 1487443 URL: http://svn.apache.org/r1487443 Log: * Avoid compilation warning * More explicit error message Modified: felix/trunk/ipojo/runtime/core/src/main/java/org/apache/felix/ipojo/extender/internal/processor/ExtensionBundleProcessor.java Modified: felix/trunk/ipojo/runtime/core/src/main/java/org/apache/felix/ipojo/extender/internal/processor/ExtensionBundleProcessor.java URL: http://svn.apache.org/viewvc/felix/trunk/ipojo/runtime/core/src/main/java/org/apache/felix/ipojo/extender/internal/processor/ExtensionBundleProcessor.java?rev=1487443&r1=1487442&r2=1487443&view=diff ============================================================================== --- felix/trunk/ipojo/runtime/core/src/main/java/org/apache/felix/ipojo/extender/internal/processor/ExtensionBundleProcessor.java (original) +++ felix/trunk/ipojo/runtime/core/src/main/java/org/apache/felix/ipojo/extender/internal/processor/ExtensionBundleProcessor.java Wed May 29 11:48:38 2013 @@ -19,6 +19,7 @@ package org.apache.felix.ipojo.extender.internal.processor; +import org.apache.felix.ipojo.IPojoFactory; import org.apache.felix.ipojo.extender.internal.BundleProcessor; import org.apache.felix.ipojo.extender.internal.builder.ReflectiveFactoryBuilder; import org.apache.felix.ipojo.extender.internal.declaration.DefaultExtensionDeclaration; @@ -125,12 +126,18 @@ public class ExtensionBundleProcessor im */ String[] nameparts = ParseUtils.split(segments[0].trim(), " \t"); String type = nameparts.length == 1 ? nameparts[0] : nameparts[0] + ":" + nameparts[1]; + String classname = segments[1]; - Class clazz; + Class clazz; try { - clazz = bundle.loadClass(segments[1]); + clazz = bundle.loadClass(classname).asSubclass(IPojoFactory.class); } catch (ClassNotFoundException e) { - m_logger.log(Logger.ERROR, "Cannot load the extension " + type, e); + String message = String.format("Cannot load class '%s' from bundle %s (%s) for extension '%s'", + classname, + bundle.getSymbolicName(), + bundle.getVersion(), + type); + m_logger.log(Logger.ERROR, message, e); return; }