felix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clem...@apache.org
Subject svn commit: r1486736 - /felix/trunk/ipojo/runtime/core/src/main/java/org/apache/felix/ipojo/IPojoFactory.java
Date Tue, 28 May 2013 04:32:46 GMT
Author: clement
Date: Tue May 28 04:32:46 2013
New Revision: 1486736

URL: http://svn.apache.org/r1486736
Log:
 FELIX-4076 - Useless locking on getRequiredHandler
 
 Remove useless synchronized

Modified:
    felix/trunk/ipojo/runtime/core/src/main/java/org/apache/felix/ipojo/IPojoFactory.java

Modified: felix/trunk/ipojo/runtime/core/src/main/java/org/apache/felix/ipojo/IPojoFactory.java
URL: http://svn.apache.org/viewvc/felix/trunk/ipojo/runtime/core/src/main/java/org/apache/felix/ipojo/IPojoFactory.java?rev=1486736&r1=1486735&r2=1486736&view=diff
==============================================================================
--- felix/trunk/ipojo/runtime/core/src/main/java/org/apache/felix/ipojo/IPojoFactory.java
(original)
+++ felix/trunk/ipojo/runtime/core/src/main/java/org/apache/felix/ipojo/IPojoFactory.java
Tue May 28 04:32:46 2013
@@ -366,7 +366,7 @@ public abstract class IPojoFactory imple
     }
 
     /**
-     * Computes the list of missing handlers. This method is called with the monitor lock.
+     * Computes the list of missing handlers.
      * @return the list of missing handlers.
      * @see org.apache.felix.ipojo.Factory#getMissingHandlers()
      */
@@ -392,12 +392,11 @@ public abstract class IPojoFactory imple
 
     /**
      * Gets the list of required handlers.
-     * This method is synchronized to avoid the concurrent modification
-     * of the required handlers.
+     * The required handler list cannot change.
      * @return the list of required handlers.
      * @see org.apache.felix.ipojo.Factory#getRequiredHandlers()
      */
-    public synchronized List<String> getRequiredHandlers() {
+    public List<String> getRequiredHandlers() {
         List<String> list = new ArrayList<String>();
         for (RequiredHandler req : m_requiredHandlers) {
             list.add(req.getFullName());



Mime
View raw message