felix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chet...@apache.org
Subject svn commit: r1453295 - in /felix/trunk/jaas/src/main/java/org/apache/felix/jaas: LoginModuleFactory.java internal/Activator.java internal/ConfigLoginModuleProvider.java internal/ConfigSpiOsgi.java internal/LoginModuleProvider.java
Date Wed, 06 Mar 2013 11:24:14 GMT
Author: chetanm
Date: Wed Mar  6 11:24:14 2013
New Revision: 1453295

URL: http://svn.apache.org/r1453295
Log:
Minor code formatting and adding some javadocs

Modified:
    felix/trunk/jaas/src/main/java/org/apache/felix/jaas/LoginModuleFactory.java
    felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/Activator.java
    felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/ConfigLoginModuleProvider.java
    felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/ConfigSpiOsgi.java
    felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/LoginModuleProvider.java

Modified: felix/trunk/jaas/src/main/java/org/apache/felix/jaas/LoginModuleFactory.java
URL: http://svn.apache.org/viewvc/felix/trunk/jaas/src/main/java/org/apache/felix/jaas/LoginModuleFactory.java?rev=1453295&r1=1453294&r2=1453295&view=diff
==============================================================================
--- felix/trunk/jaas/src/main/java/org/apache/felix/jaas/LoginModuleFactory.java (original)
+++ felix/trunk/jaas/src/main/java/org/apache/felix/jaas/LoginModuleFactory.java Wed Mar 
6 11:24:14 2013
@@ -21,18 +21,33 @@ package org.apache.felix.jaas;
 
 import javax.security.auth.spi.LoginModule;
 
-
 /**
- * User: chetanm
- * Date: 7/9/12
- * Time: 5:43 PM
+ * 
  */
 public interface LoginModuleFactory
 {
-
+    /**
+     * Property name specifying whether or not a <code>LoginModule</code> is
+     * REQUIRED, REQUISITE, SUFFICIENT or OPTIONAL. Refer to {@link javax.security.auth.login.Configuration}
+     * for more details around the meaning of these flags
+     *
+     * By default the value is set to REQUIRED
+     */
     String JAAS_CONTROL_FLAG = "jaas.controlFlag";
+
+    /**
+     * Property name specifying the Realm name (or application name) against which the
+     * LoginModule would be registered.
+     *
+     * <p>If no realm name is provided then LoginModule would registered with a default
realm
+     * as configured
+     */
     String JAAS_REALM_NAME = "jaas.realmName";
 
+    /**
+     * Creates the LoginModule instance
+     * @return loginModule instance
+     */
     LoginModule createLoginModule();
 
 }

Modified: felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/Activator.java
URL: http://svn.apache.org/viewvc/felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/Activator.java?rev=1453295&r1=1453294&r2=1453295&view=diff
==============================================================================
--- felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/Activator.java (original)
+++ felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/Activator.java Wed Mar 
6 11:24:14 2013
@@ -38,8 +38,7 @@ public class Activator implements Bundle
         loginModuleCreator = new BundleLoginModuleCreator(context, logger);
         jaasConfigFactory = new JaasConfigFactory(context, loginModuleCreator, logger);
         configSpi = new ConfigSpiOsgi(context, logger);
-        webConsolePlugin = new JaasWebConsolePlugin(context, configSpi,
-            loginModuleCreator);
+        webConsolePlugin = new JaasWebConsolePlugin(context, configSpi,loginModuleCreator);
 
         logger.open();
         loginModuleCreator.open();

Modified: felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/ConfigLoginModuleProvider.java
URL: http://svn.apache.org/viewvc/felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/ConfigLoginModuleProvider.java?rev=1453295&r1=1453294&r2=1453295&view=diff
==============================================================================
--- felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/ConfigLoginModuleProvider.java
(original)
+++ felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/ConfigLoginModuleProvider.java
Wed Mar  6 11:24:14 2013
@@ -37,7 +37,9 @@ final class ConfigLoginModuleProvider im
     private final LoginModuleCreator moduleCreator;
 
     @SuppressWarnings("unchecked")
-    ConfigLoginModuleProvider(String realmName, String className, Map options, LoginModuleControlFlag
controlFlag, int order, LoginModuleCreator moduleCreator)
+    ConfigLoginModuleProvider(String realmName, String className, Map options,
+                              LoginModuleControlFlag controlFlag, int order,
+                              LoginModuleCreator moduleCreator)
     {
         this.options = Collections.unmodifiableMap(options);
         this.controlFlag = controlFlag;

Modified: felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/ConfigSpiOsgi.java
URL: http://svn.apache.org/viewvc/felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/ConfigSpiOsgi.java?rev=1453295&r1=1453294&r2=1453295&view=diff
==============================================================================
--- felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/ConfigSpiOsgi.java (original)
+++ felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/ConfigSpiOsgi.java Wed Mar
 6 11:24:14 2013
@@ -47,8 +47,14 @@ import org.osgi.service.log.LogService;
 import org.osgi.util.tracker.ServiceTracker;
 import org.osgi.util.tracker.ServiceTrackerCustomizer;
 
-@Component(label = "%jaas.spi.name", description = "%jaas.spi.description", metatype = true,
ds = false, name = "org.apache.felix.jaas.ConfigurationSpi", policy = ConfigurationPolicy.REQUIRE)
-public class ConfigSpiOsgi extends ConfigurationSpi implements ManagedService, ServiceTrackerCustomizer,
LoginContextFactory
+@Component(label = "%jaas.spi.name",
+        description = "%jaas.spi.description",
+        metatype = true,
+        ds = false,
+        name = "org.apache.felix.jaas.ConfigurationSpi",
+        policy = ConfigurationPolicy.REQUIRE)
+public class ConfigSpiOsgi extends ConfigurationSpi implements ManagedService,
+        ServiceTrackerCustomizer, LoginContextFactory
 {
     /**
      * Name of the algorithm to use to fetch JAAS Config

Modified: felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/LoginModuleProvider.java
URL: http://svn.apache.org/viewvc/felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/LoginModuleProvider.java?rev=1453295&r1=1453294&r2=1453295&view=diff
==============================================================================
--- felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/LoginModuleProvider.java
(original)
+++ felix/trunk/jaas/src/main/java/org/apache/felix/jaas/internal/LoginModuleProvider.java
Wed Mar  6 11:24:14 2013
@@ -35,6 +35,10 @@ public interface LoginModuleProvider ext
 
     int ranking();
 
+    /**
+     * Realm name with which LoginModule is registered. Can be <code>null</code>
+     * @return realmName or null if not provided
+     */
     String realmName();
 
     String getClassName();



Mime
View raw message