Return-Path: Delivered-To: apmail-felix-commits-archive@www.apache.org Received: (qmail 42266 invoked from network); 5 Apr 2010 07:50:02 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 5 Apr 2010 07:50:02 -0000 Received: (qmail 64943 invoked by uid 500); 5 Apr 2010 07:50:02 -0000 Delivered-To: apmail-felix-commits-archive@felix.apache.org Received: (qmail 64923 invoked by uid 500); 5 Apr 2010 07:50:02 -0000 Mailing-List: contact commits-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list commits@felix.apache.org Received: (qmail 64916 invoked by uid 99); 5 Apr 2010 07:50:02 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Apr 2010 07:50:02 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Apr 2010 07:49:59 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id B472A238896F; Mon, 5 Apr 2010 07:49:38 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r930810 - /felix/trunk/dependencymanager/annotation/src/main/java/org/apache/felix/dm/annotation/plugin/mvn/AnnotationMojo.java Date: Mon, 05 Apr 2010 07:49:38 -0000 To: commits@felix.apache.org From: pderop@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100405074938.B472A238896F@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: pderop Date: Mon Apr 5 07:49:38 2010 New Revision: 930810 URL: http://svn.apache.org/viewvc?rev=930810&view=rev Log: fixed findbugs warning: File.exists() and File.delete() return value was not checked Modified: felix/trunk/dependencymanager/annotation/src/main/java/org/apache/felix/dm/annotation/plugin/mvn/AnnotationMojo.java Modified: felix/trunk/dependencymanager/annotation/src/main/java/org/apache/felix/dm/annotation/plugin/mvn/AnnotationMojo.java URL: http://svn.apache.org/viewvc/felix/trunk/dependencymanager/annotation/src/main/java/org/apache/felix/dm/annotation/plugin/mvn/AnnotationMojo.java?rev=930810&r1=930809&r2=930810&view=diff ============================================================================== --- felix/trunk/dependencymanager/annotation/src/main/java/org/apache/felix/dm/annotation/plugin/mvn/AnnotationMojo.java (original) +++ felix/trunk/dependencymanager/annotation/src/main/java/org/apache/felix/dm/annotation/plugin/mvn/AnnotationMojo.java Mon Apr 5 07:49:38 2010 @@ -186,7 +186,9 @@ public class AnnotationMojo extends Abst finally { jar.close(); - tmp.delete(); + if (tmp.exists() && ! tmp.delete()) { + throw new MojoExecutionException("Could not remove " + tmp); + } } } }