felix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fmesc...@apache.org
Subject svn commit: r931719 - /felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/servlet/PluginHolder.java
Date Wed, 07 Apr 2010 23:14:21 GMT
Author: fmeschbe
Date: Wed Apr  7 23:14:21 2010
New Revision: 931719

URL: http://svn.apache.org/viewvc?rev=931719&view=rev
Log:
FELIX-2246 Do not check for label property twice upon service events

Modified:
    felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/servlet/PluginHolder.java

Modified: felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/servlet/PluginHolder.java
URL: http://svn.apache.org/viewvc/felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/servlet/PluginHolder.java?rev=931719&r1=931718&r2=931719&view=diff
==============================================================================
--- felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/servlet/PluginHolder.java
(original)
+++ felix/trunk/webconsole/src/main/java/org/apache/felix/webconsole/internal/servlet/PluginHolder.java
Wed Apr  7 23:14:21 2010
@@ -301,25 +301,21 @@ class PluginHolder implements ServiceLis
      */
     public void serviceChanged( ServiceEvent event )
     {
-        final String label = getProperty( event.getServiceReference(), WebConsoleConstants.PLUGIN_LABEL
);
-        if ( label != null )
+        switch ( event.getType() )
         {
-            switch ( event.getType() )
-            {
-                case ServiceEvent.REGISTERED:
-                    // add service
-                    serviceAdded( event.getServiceReference() );
-                    break;
-
-                case ServiceEvent.UNREGISTERING:
-                    // remove service
-                    serviceRemoved( event.getServiceReference() );
-                    break;
-
-                default:
-                    // update service
-                    break;
-            }
+            case ServiceEvent.REGISTERED:
+                // add service
+                serviceAdded( event.getServiceReference() );
+                break;
+
+            case ServiceEvent.UNREGISTERING:
+                // remove service
+                serviceRemoved( event.getServiceReference() );
+                break;
+
+            default:
+                // update service
+                break;
         }
     }
 



Mime
View raw message