felix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rickh...@apache.org
Subject svn commit: r929973 - /felix/trunk/framework/src/main/java/org/apache/felix/framework/cache/BundleArchive.java
Date Thu, 01 Apr 2010 13:47:19 GMT
Author: rickhall
Date: Thu Apr  1 13:47:18 2010
New Revision: 929973

URL: http://svn.apache.org/viewvc?rev=929973&view=rev
Log:
Minor formatting edits. (FELIX-2195)

Modified:
    felix/trunk/framework/src/main/java/org/apache/felix/framework/cache/BundleArchive.java

Modified: felix/trunk/framework/src/main/java/org/apache/felix/framework/cache/BundleArchive.java
URL: http://svn.apache.org/viewvc/felix/trunk/framework/src/main/java/org/apache/felix/framework/cache/BundleArchive.java?rev=929973&r1=929972&r2=929973&view=diff
==============================================================================
--- felix/trunk/framework/src/main/java/org/apache/felix/framework/cache/BundleArchive.java
(original)
+++ felix/trunk/framework/src/main/java/org/apache/felix/framework/cache/BundleArchive.java
Thu Apr  1 13:47:18 2010
@@ -1039,8 +1039,8 @@ public class BundleArchive
         return result;
     }
 
-    //method from Harmony java.net.URIEncoderDecoder (luni subproject) used by URI to decode
uri components.
-    static final String encoding = "UTF8"; //$NON-NLS-1$
+    // Method from Harmony java.net.URIEncoderDecoder (luni subproject)
+    // used by URI to decode uri components.
     private static String decode(String s) throws UnsupportedEncodingException 
     {
         StringBuffer result = new StringBuffer();
@@ -1053,20 +1053,24 @@ public class BundleArchive
                 out.reset();
                 do 
                 {
-                    if (i + 2 >= s.length()) 
+                    if ((i + 2) >= s.length()) 
                     {
-                        throw new IllegalArgumentException("Incomplete % sequence at: " +
i);
+                        throw new IllegalArgumentException(
+                            "Incomplete % sequence at: " + i);
                     }
                     int d1 = Character.digit(s.charAt(i + 1), 16);
                     int d2 = Character.digit(s.charAt(i + 2), 16);
-                    if (d1 == -1 || d2 == -1) 
+                    if ((d1 == -1) || (d2 == -1))
                     {
-                        throw new IllegalArgumentException("Invalid % sequence (" + s.substring(i,
i + 3) + ") at: " + String.valueOf(i));
+                        throw new IllegalArgumentException("Invalid % sequence ("
+                            + s.substring(i, i + 3)
+                            + ") at: " + String.valueOf(i));
                     }
                     out.write((byte) ((d1 << 4) + d2));
                     i += 3;
-                } while (i < s.length() && s.charAt(i) == '%');
-                result.append(out.toString(encoding));
+                }
+                while ((i < s.length()) && (s.charAt(i) == '%'));
+                result.append(out.toString("UTF-8"));
                 continue;
             }
             result.append(c);



Mime
View raw message