Return-Path: Delivered-To: apmail-felix-commits-archive@www.apache.org Received: (qmail 90434 invoked from network); 3 Feb 2008 21:13:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Feb 2008 21:13:55 -0000 Received: (qmail 7979 invoked by uid 500); 3 Feb 2008 21:13:47 -0000 Delivered-To: apmail-felix-commits-archive@felix.apache.org Received: (qmail 7954 invoked by uid 500); 3 Feb 2008 21:13:47 -0000 Mailing-List: contact commits-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list commits@felix.apache.org Received: (qmail 7941 invoked by uid 99); 3 Feb 2008 21:13:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Feb 2008 13:13:47 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Feb 2008 21:13:40 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 8A3751A9832; Sun, 3 Feb 2008 13:13:32 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r618090 - /felix/trunk/framework/src/main/java/org/apache/felix/framework/PackageAdminImpl.java Date: Sun, 03 Feb 2008 21:13:32 -0000 To: commits@felix.apache.org From: pauls@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080203211332.8A3751A9832@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: pauls Date: Sun Feb 3 13:13:30 2008 New Revision: 618090 URL: http://svn.apache.org/viewvc?rev=618090&view=rev Log: Remove an unneccessary object creation. Modified: felix/trunk/framework/src/main/java/org/apache/felix/framework/PackageAdminImpl.java Modified: felix/trunk/framework/src/main/java/org/apache/felix/framework/PackageAdminImpl.java URL: http://svn.apache.org/viewvc/felix/trunk/framework/src/main/java/org/apache/felix/framework/PackageAdminImpl.java?rev=618090&r1=618089&r2=618090&view=diff ============================================================================== --- felix/trunk/framework/src/main/java/org/apache/felix/framework/PackageAdminImpl.java (original) +++ felix/trunk/framework/src/main/java/org/apache/felix/framework/PackageAdminImpl.java Sun Feb 3 13:13:30 2008 @@ -26,6 +26,15 @@ class PackageAdminImpl implements PackageAdmin, Runnable { + private static final Comparator COMPARATOR = new Comparator() { + public int compare(Object o1, Object o2) + { + // Reverse arguments to sort in descending order. + return ((ExportedPackage) o2).getVersion().compareTo( + ((ExportedPackage) o1).getVersion()); + } + }; + private Felix m_felix = null; private Bundle[][] m_reqBundles = null; private Bundle m_systemBundle = null; @@ -153,14 +162,7 @@ return null; } // Sort the exported versions. - Arrays.sort(pkgs, new Comparator() { - public int compare(Object o1, Object o2) - { - // Reverse arguments to sort in descending order. - return ((ExportedPackage) o2).getVersion().compareTo( - ((ExportedPackage) o1).getVersion()); - } - }); + Arrays.sort(pkgs, COMPARATOR); // Return the highest version. return pkgs[0]; }