felix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pa...@apache.org
Subject svn commit: r397848 - in /incubator/felix/sandbox/pauls/org.apache.felix.eventadmin/src/main/java/org/apache/felix/eventadmin/impl: Activator.java EventAdminImpl.java adapter/BundleEventAdapter.java
Date Fri, 28 Apr 2006 10:40:14 GMT
Author: pauls
Date: Fri Apr 28 03:40:11 2006
New Revision: 397848

URL: http://svn.apache.org/viewcvs?rev=397848&view=rev
Log:
Some more doc fixes

Modified:
    incubator/felix/sandbox/pauls/org.apache.felix.eventadmin/src/main/java/org/apache/felix/eventadmin/impl/Activator.java
    incubator/felix/sandbox/pauls/org.apache.felix.eventadmin/src/main/java/org/apache/felix/eventadmin/impl/EventAdminImpl.java
    incubator/felix/sandbox/pauls/org.apache.felix.eventadmin/src/main/java/org/apache/felix/eventadmin/impl/adapter/BundleEventAdapter.java

Modified: incubator/felix/sandbox/pauls/org.apache.felix.eventadmin/src/main/java/org/apache/felix/eventadmin/impl/Activator.java
URL: http://svn.apache.org/viewcvs/incubator/felix/sandbox/pauls/org.apache.felix.eventadmin/src/main/java/org/apache/felix/eventadmin/impl/Activator.java?rev=397848&r1=397847&r2=397848&view=diff
==============================================================================
--- incubator/felix/sandbox/pauls/org.apache.felix.eventadmin/src/main/java/org/apache/felix/eventadmin/impl/Activator.java
(original)
+++ incubator/felix/sandbox/pauls/org.apache.felix.eventadmin/src/main/java/org/apache/felix/eventadmin/impl/Activator.java
Fri Apr 28 03:40:11 2006
@@ -161,13 +161,13 @@
         final int cacheSize = getIntProperty("org.apache.felix.eventadmin.CacheSize", 
             context, 30, 10);
 
-        // The size of the internal thread pool. Note that since we must execute
+        // The size of the internal thread pool. Note that we must execute
         // each synchronous event dispatch that happens in the synchronous event
         // dispatching thread in a new thread, hence a small thread pool is o.k.
         // A value of less then 2 triggers the default value. A value of 2 
         // effectively disables thread pooling. Furthermore, this will be used by 
         // a lazy thread pool (i.e., new threads are created when needed). Ones the
-        // the size is reached and now cached thread is available new threads will
+        // the size is reached and no cached thread is available new threads will
         // be created.
         final int threadPoolSize = getIntProperty(
             "org.apache.felix.eventadmin.ThreadPoolSize", context, 10, 2);
@@ -212,9 +212,9 @@
             new LeastRecentlyUsedCacheMap(cacheSize), context);
         
         // The handlerTasks object is responsible to determine concerned EventHandler
-        // for a given event. Additionally, it keeps a list of blacklisted tasks.
+        // for a given event. Additionally, it keeps a list of blacklisted handlers.
         // Note that blacklisting is deactivated by selecting a different scheduler
-        // below (and not in the HandlerTasks!)
+        // below (and not in this HandlerTasks object!)
         final HandlerTasks handlerTasks = new BlacklistingHandlerTasks(context, 
             new CleanBlackList(), topicHandlerFilters, filters, 
             subscribePermissions);
@@ -243,6 +243,7 @@
         context.registerService(EventAdmin.class.getName(), 
             new SecureEventAdminFactory(m_admin, publishPermissions), null);
         
+        // Finally, adapt the outside events to our kind of events as per spec
         adaptEvents(context, m_admin);
     }
 

Modified: incubator/felix/sandbox/pauls/org.apache.felix.eventadmin/src/main/java/org/apache/felix/eventadmin/impl/EventAdminImpl.java
URL: http://svn.apache.org/viewcvs/incubator/felix/sandbox/pauls/org.apache.felix.eventadmin/src/main/java/org/apache/felix/eventadmin/impl/EventAdminImpl.java?rev=397848&r1=397847&r2=397848&view=diff
==============================================================================
--- incubator/felix/sandbox/pauls/org.apache.felix.eventadmin/src/main/java/org/apache/felix/eventadmin/impl/EventAdminImpl.java
(original)
+++ incubator/felix/sandbox/pauls/org.apache.felix.eventadmin/src/main/java/org/apache/felix/eventadmin/impl/EventAdminImpl.java
Fri Apr 28 03:40:11 2006
@@ -139,10 +139,10 @@
         {
             // This might throw an IllegalStateException in case that we are stopped
             // and the null object for m_managers was not fast enough established
-            // This is needed by use in the adapter/* classes due to them sending
+            // This is needed in the adapter/* classes due to them sending
             // events whenever they receive an event from their source.
             // Service importers that call us regardless of the fact that we are
-            // stop deserve an exception anyways
+            // stopped deserve an exception anyways
             manager.createTask().execute(managers);
         }
     }

Modified: incubator/felix/sandbox/pauls/org.apache.felix.eventadmin/src/main/java/org/apache/felix/eventadmin/impl/adapter/BundleEventAdapter.java
URL: http://svn.apache.org/viewcvs/incubator/felix/sandbox/pauls/org.apache.felix.eventadmin/src/main/java/org/apache/felix/eventadmin/impl/adapter/BundleEventAdapter.java?rev=397848&r1=397847&r2=397848&view=diff
==============================================================================
--- incubator/felix/sandbox/pauls/org.apache.felix.eventadmin/src/main/java/org/apache/felix/eventadmin/impl/adapter/BundleEventAdapter.java
(original)
+++ incubator/felix/sandbox/pauls/org.apache.felix.eventadmin/src/main/java/org/apache/felix/eventadmin/impl/adapter/BundleEventAdapter.java
Fri Apr 28 03:40:11 2006
@@ -112,7 +112,7 @@
         }
 
         try {
-        m_admin.postEvent(new Event(topic.toString(), properties));
+            m_admin.postEvent(new Event(topic.toString(), properties));
         } catch (IllegalStateException e) { 
             // This is o.k. - indicates that we are stopped.
         }



Mime
View raw message