Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AB8CC200BF7 for ; Mon, 9 Jan 2017 15:23:03 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id AA423160B3E; Mon, 9 Jan 2017 14:23:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 017E2160B3B for ; Mon, 9 Jan 2017 15:23:02 +0100 (CET) Received: (qmail 80650 invoked by uid 500); 9 Jan 2017 14:23:02 -0000 Mailing-List: contact dev-help@falcon.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@falcon.apache.org Delivered-To: mailing list dev@falcon.apache.org Received: (qmail 80639 invoked by uid 99); 9 Jan 2017 14:23:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Jan 2017 14:23:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 91FD5C0744 for ; Mon, 9 Jan 2017 14:23:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.219 X-Spam-Level: X-Spam-Status: No, score=-6.219 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id yyMy0QD4p3An for ; Mon, 9 Jan 2017 14:23:00 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 7A8A15FAC8 for ; Mon, 9 Jan 2017 14:22:59 +0000 (UTC) Received: (qmail 79184 invoked by uid 99); 9 Jan 2017 14:22:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Jan 2017 14:22:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 807322C2A66 for ; Mon, 9 Jan 2017 14:22:58 +0000 (UTC) Date: Mon, 9 Jan 2017 14:22:58 +0000 (UTC) From: "Prashant (JIRA)" To: dev@falcon.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FALCON-2234) Falcon feed fails for RDBMS import if extract type is incremental MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 09 Jan 2017 14:23:03 -0000 [ https://issues.apache.org/jira/browse/FALCON-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811891#comment-15811891 ] Prashant commented on FALCON-2234: ---------------------------------- Hi Ajay, So the desired behaviour is to remove the same from the Falcon UI? > Falcon feed fails for RDBMS import if extract type is incremental > ----------------------------------------------------------------- > > Key: FALCON-2234 > URL: https://issues.apache.org/jira/browse/FALCON-2234 > Project: Falcon > Issue Type: Bug > Components: falcon-ui > Affects Versions: 0.10 > Reporter: Prashant > Priority: Critical > Labels: documentaion, newbie > > Falcon feed is failing with org.apache.falcon.entity.parser.ValidationException > when extract type is incremental. > As per the Apache doc Falcon supports > Import policy > The valid combinations are: > [full,snapshot] - data is extracted in full and dumped into the feed instance location. > [incremental, append] - data is extracted incrementally using the key specified in the deltacolumn > As per the below code , it appears we only check [full,snapshot] and [incremental, append] goes to exception > https://github.com/apache/falcon/blob/0.10/common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java > Snippet > {code} > /** > * Validate extraction and merge type combination. Currently supported combo: > * > * ExtractionType = FULL and MergeType = SNAPSHOT. > * ExtractionType = INCREMENTAL and MergeType = APPEND. > * > * @param feed Feed entity > * @param cluster Cluster referenced in the Feed definition > * @throws FalconException > */ > private void validateFeedExtractionType(Feed feed, Cluster cluster) throws FalconException { > Extract extract = cluster.getImport().getSource().getExtract(); > if (ExtractMethod.FULL == extract.getType()) { > if ((MergeType.SNAPSHOT != extract.getMergepolicy()) > || (extract.getDeltacolumn() != null)) { > throw new ValidationException(String.format("Feed %s is using FULL " > + "extract method but specifies either a superfluous " > + "deltacolumn or a mergepolicy other than snapshot", feed.getName())); > } > } else { > throw new ValidationException(String.format("Feed %s is using unsupported " > + "extraction mechanism %s", feed.getName(), extract.getType().value())); > } > } > {code} > It must have a clause to also check [incremental, append] . -- This message was sent by Atlassian JIRA (v6.3.4#6332)